Android/scrcpy
1
0
Fork 0
Code Issues Pull requests Projects Releases 1 Packages Wiki Activity
scrcpy/app/src/control_event.c

63 lines
2.3 KiB
C
Raw Normal View History

Separate multi-words filenames by '_' Rename foobar.ext to foo_bar.ext. <https://github.com/Genymobile/scrcpy/pull/226#discussion_r209454865>
2018-08-15 23:01:54 +08:00
#include "control_event.h"
Implement keyboard/mouse control To control the device from the computer: - retrieve mouse and keyboard SDL events; - convert them to Android events; - serialize them; - send them on the same socket used by the video stream (but in the opposite direction); - deserialize the events on the Android side; - inject them using the InputManager.
2017-12-14 18:38:44 +08:00
Add missing includes Include string.h and stdio.h explicitly.
2018-05-13 21:33:13 +08:00
#include <string.h>
Implement keyboard/mouse control To control the device from the computer: - retrieve mouse and keyboard SDL events; - convert them to Android events; - serialize them; - send them on the same socket used by the video stream (but in the opposite direction); - deserialize the events on the Android side; - inject them using the InputManager.
2017-12-14 18:38:44 +08:00
Extract bit operations to buffer_util.h Move util functions to a reusable separate header.
2018-11-11 07:48:25 +08:00
#include "buffer_util.h"
Define macros wrappers for logs Use macros to wrap SDL_Log* functions with the "application" category.
2018-02-13 17:10:18 +08:00
#include "log.h"
Truncate UTF-8 properly This will avoid to produce invalid UTF-8 results (although unlikely).
2019-05-31 01:13:19 +08:00
#include "str_util.h"
Implement keyboard/mouse control To control the device from the computer: - retrieve mouse and keyboard SDL events; - convert them to Android events; - serialize them; - send them on the same socket used by the video stream (but in the opposite direction); - deserialize the events on the Android side; - inject them using the InputManager.
2017-12-14 18:38:44 +08:00
Update code style Limit source code to 80 chars, and declare functions return type and modifiers on a separate line. This allows to avoid very long lines, and all function names are aligned. (We do this on VLC, and I like it.)
2019-03-03 03:09:56 +08:00
static void
Replace SDL types by C99 standard types Scrcpy is a C11 project. Use the C99 standard types instead of the SDL-specific types: SDL_bool -> bool SintXX -> intXX_t UintXX -> uintXX_t
2019-03-03 06:52:22 +08:00
write_position(uint8_t *buf, const struct position *position) {
Handle mouse events outside device screen Mouse events position were unsigned (so negative values could not be handled properly). To avoid issues with negative values, mouse events outside the device screen were ignored (commit a7fe9ad779057f7a2698fc1769dce3c3786993ee). But as a consequence, drag&drop were "broken" if the "drop" occurred outside the device screen. Instead, use signed 32-bits to store the position, and forward events outside the device screen. Fixes <https://github.com/Genymobile/scrcpy/issues/357>.
2018-11-27 15:54:31 +08:00
buffer_write32be(&buf[0], position->point.x);
buffer_write32be(&buf[4], position->point.y);
buffer_write16be(&buf[8], position->screen_size.width);
buffer_write16be(&buf[10], position->screen_size.height);
Scale mouse events The video screen size on the client may differ from the real device screen size (e.g. the video stream may be scaled down). As a consequence, mouse events must be scaled to match the real device coordinates. For this purpose, make the client send the video screen size along with the absolute pointer location, and the server scale the location to match the real device size before injecting mouse events.
2018-01-22 23:50:08 +08:00
}
Make control_event_serialize() return size_t control_event_serialize() returns the number of bytes written, so the type should be size_t.
2019-05-29 23:26:21 +08:00
size_t
Update code style Limit source code to 80 chars, and declare functions return type and modifiers on a separate line. This allows to avoid very long lines, and all function names are aligned. (We do this on VLC, and I like it.)
2019-03-03 03:09:56 +08:00
control_event_serialize(const struct control_event *event, unsigned char *buf) {
Implement keyboard/mouse control To control the device from the computer: - retrieve mouse and keyboard SDL events; - convert them to Android events; - serialize them; - send them on the same socket used by the video stream (but in the opposite direction); - deserialize the events on the Android side; - inject them using the InputManager.
2017-12-14 18:38:44 +08:00
buf[0] = event->type;
switch (event->type) {
Indent switch blocks content For readability, indent "case" in switch blocks. Replace: switch (x) { case 1: // ... case 2: // ... case 3: { // a local scope block int i = 42; // ... } } By: switch (x) { case 1: // ... case 2: // ... case 3: { // a local scope block int i = 42; // ... } }
2018-02-01 18:34:49 +08:00
case CONTROL_EVENT_TYPE_KEYCODE:
buf[1] = event->keycode_event.action;
Extract bit operations to buffer_util.h Move util functions to a reusable separate header.
2018-11-11 07:48:25 +08:00
buffer_write32be(&buf[2], event->keycode_event.keycode);
buffer_write32be(&buf[6], event->keycode_event.metastate);
Indent switch blocks content For readability, indent "case" in switch blocks. Replace: switch (x) { case 1: // ... case 2: // ... case 3: { // a local scope block int i = 42; // ... } } By: switch (x) { case 1: // ... case 2: // ... case 3: { // a local scope block int i = 42; // ... } }
2018-02-01 18:34:49 +08:00
return 10;
case CONTROL_EVENT_TYPE_TEXT: {
Fix incorrect comment Comment had not been updated along with the code.
2019-01-22 16:38:51 +08:00
// write length (2 bytes) + string (non nul-terminated)
Truncate UTF-8 properly This will avoid to produce invalid UTF-8 results (although unlikely).
2019-05-31 01:13:19 +08:00
// injecting a text takes time, so limit the text length
size_t len = utf8_truncation_index(event->text_event.text,
CONTROL_EVENT_TEXT_MAX_LENGTH);
Replace SDL types by C99 standard types Scrcpy is a C11 project. Use the C99 standard types instead of the SDL-specific types: SDL_bool -> bool SintXX -> intXX_t UintXX -> uintXX_t
2019-03-03 06:52:22 +08:00
buffer_write16be(&buf[1], (uint16_t) len);
Fix text input event segfault The text input control_event was initially designed for mapping SDL_TextInputEvent, limited to 32 characters. For simplicity, the copy/paste feature was implemented using the same control_event: it just sends the text to paste. However, the pasted text might have a length breaking some assumptions: - on the client, the event max-size was smaller than the text max-length, - on the server, the raw buffer storing the events was smaller than the max event size. Fix these inconsistencies, and encode the length on 2 bytes, to accept more than 256 characters. Fixes <https://github.com/Genymobile/scrcpy/issues/10>.
2018-03-10 04:47:14 +08:00
memcpy(&buf[3], event->text_event.text, len);
return 3 + len;
Implement keyboard/mouse control To control the device from the computer: - retrieve mouse and keyboard SDL events; - convert them to Android events; - serialize them; - send them on the same socket used by the video stream (but in the opposite direction); - deserialize the events on the Android side; - inject them using the InputManager.
2017-12-14 18:38:44 +08:00
}
Indent switch blocks content For readability, indent "case" in switch blocks. Replace: switch (x) { case 1: // ... case 2: // ... case 3: { // a local scope block int i = 42; // ... } } By: switch (x) { case 1: // ... case 2: // ... case 3: { // a local scope block int i = 42; // ... } }
2018-02-01 18:34:49 +08:00
case CONTROL_EVENT_TYPE_MOUSE:
buf[1] = event->mouse_event.action;
Extract bit operations to buffer_util.h Move util functions to a reusable separate header.
2018-11-11 07:48:25 +08:00
buffer_write32be(&buf[2], event->mouse_event.buttons);
Indent switch blocks content For readability, indent "case" in switch blocks. Replace: switch (x) { case 1: // ... case 2: // ... case 3: { // a local scope block int i = 42; // ... } } By: switch (x) { case 1: // ... case 2: // ... case 3: { // a local scope block int i = 42; // ... } }
2018-02-01 18:34:49 +08:00
write_position(&buf[6], &event->mouse_event.position);
Handle mouse events outside device screen Mouse events position were unsigned (so negative values could not be handled properly). To avoid issues with negative values, mouse events outside the device screen were ignored (commit a7fe9ad779057f7a2698fc1769dce3c3786993ee). But as a consequence, drag&drop were "broken" if the "drop" occurred outside the device screen. Instead, use signed 32-bits to store the position, and forward events outside the device screen. Fixes <https://github.com/Genymobile/scrcpy/issues/357>.
2018-11-27 15:54:31 +08:00
return 18;
Indent switch blocks content For readability, indent "case" in switch blocks. Replace: switch (x) { case 1: // ... case 2: // ... case 3: { // a local scope block int i = 42; // ... } } By: switch (x) { case 1: // ... case 2: // ... case 3: { // a local scope block int i = 42; // ... } }
2018-02-01 18:34:49 +08:00
case CONTROL_EVENT_TYPE_SCROLL:
write_position(&buf[1], &event->scroll_event.position);
Replace SDL types by C99 standard types Scrcpy is a C11 project. Use the C99 standard types instead of the SDL-specific types: SDL_bool -> bool SintXX -> intXX_t UintXX -> uintXX_t
2019-03-03 06:52:22 +08:00
buffer_write32be(&buf[13], (uint32_t) event->scroll_event.hscroll);
buffer_write32be(&buf[17], (uint32_t) event->scroll_event.vscroll);
Handle mouse events outside device screen Mouse events position were unsigned (so negative values could not be handled properly). To avoid issues with negative values, mouse events outside the device screen were ignored (commit a7fe9ad779057f7a2698fc1769dce3c3786993ee). But as a consequence, drag&drop were "broken" if the "drop" occurred outside the device screen. Instead, use signed 32-bits to store the position, and forward events outside the device screen. Fixes <https://github.com/Genymobile/scrcpy/issues/357>.
2018-11-27 15:54:31 +08:00
return 21;
Merge commands with other control events Several commands were grouped under the same event type "command", with a separate field to indicate the actual command. Move these commands at the same level as other control events. It will allow to implement commands with arguments.
2019-05-30 22:07:24 +08:00
case CONTROL_EVENT_TYPE_BACK_OR_SCREEN_ON:
case CONTROL_EVENT_TYPE_EXPAND_NOTIFICATION_PANEL:
case CONTROL_EVENT_TYPE_COLLAPSE_NOTIFICATION_PANEL:
// no additional data
return 1;
Indent switch blocks content For readability, indent "case" in switch blocks. Replace: switch (x) { case 1: // ... case 2: // ... case 3: { // a local scope block int i = 42; // ... } } By: switch (x) { case 1: // ... case 2: // ... case 3: { // a local scope block int i = 42; // ... } }
2018-02-01 18:34:49 +08:00
default:
Define macros wrappers for logs Use macros to wrap SDL_Log* functions with the "application" category.
2018-02-13 17:10:18 +08:00
LOGW("Unknown event type: %u", (unsigned) event->type);
Indent switch blocks content For readability, indent "case" in switch blocks. Replace: switch (x) { case 1: // ... case 2: // ... case 3: { // a local scope block int i = 42; // ... } } By: switch (x) { case 1: // ... case 2: // ... case 3: { // a local scope block int i = 42; // ... } }
2018-02-01 18:34:49 +08:00
return 0;
Implement keyboard/mouse control To control the device from the computer: - retrieve mouse and keyboard SDL events; - convert them to Android events; - serialize them; - send them on the same socket used by the video stream (but in the opposite direction); - deserialize the events on the Android side; - inject them using the InputManager.
2017-12-14 18:38:44 +08:00
}
}
Update code style Limit source code to 80 chars, and declare functions return type and modifiers on a separate line. This allows to avoid very long lines, and all function names are aligned. (We do this on VLC, and I like it.)
2019-03-03 03:09:56 +08:00
void
control_event_destroy(struct control_event *event) {
Implement clipboard paste Paste computer clipboard to the device on Ctrl+v. The other direction (pasting the device clipboard to the computer) is not implemented. It would require a communication channel from the device to the computer, other than the socket used by the video stream.
2018-03-07 22:29:33 +08:00
if (event->type == CONTROL_EVENT_TYPE_TEXT) {
SDL_free(event->text_event.text);
}
}
Reference in a new issue Copy permalink