Prevent killing unexpected process
A missing initialization (fixed by the previous commit) leaded to kill unexpected process. In order to prevent consequences of similar errors in the future, never call kill() with a non-positive PID. See <https://github.com/Genymobile/scrcpy/issues/182>.
This commit is contained in:
parent
1a0139321b
commit
1846d2f078
1 changed files with 6 additions and 0 deletions
|
@ -1,9 +1,11 @@
|
|||
#include "command.h"
|
||||
|
||||
#include <signal.h>
|
||||
#include <stdlib.h>
|
||||
#include <sys/types.h>
|
||||
#include <sys/wait.h>
|
||||
#include <unistd.h>
|
||||
#include "log.h"
|
||||
|
||||
pid_t cmd_execute(const char *path, const char *const argv[]) {
|
||||
pid_t pid = fork();
|
||||
|
@ -20,6 +22,10 @@ pid_t cmd_execute(const char *path, const char *const argv[]) {
|
|||
}
|
||||
|
||||
SDL_bool cmd_terminate(pid_t pid) {
|
||||
if (pid <= 0) {
|
||||
LOGC("Requested to kill %d, this is an error. Please report the bug.\n", (int) pid);
|
||||
abort();
|
||||
}
|
||||
return kill(pid, SIGTERM) != -1;
|
||||
}
|
||||
|
||||
|
|
Loading…
Reference in a new issue