From 29828aa3307c78f54a3169db156222ae91182468 Mon Sep 17 00:00:00 2001
From: Romain Vimont <rom@rom1v.com>
Date: Wed, 9 Feb 2022 09:51:22 +0100
Subject: [PATCH] Log device opening errors during listing

Without this log, the user would have no way to know that a USB device
is rejected because it could not be opened (typically due to
insufficient permissions).
---
 app/src/usb/usb.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/app/src/usb/usb.c b/app/src/usb/usb.c
index 9edb1866..c7963726 100644
--- a/app/src/usb/usb.c
+++ b/app/src/usb/usb.c
@@ -38,6 +38,10 @@ sc_usb_read_device(libusb_device *device, struct sc_usb_device *out) {
     libusb_device_handle *handle;
     result = libusb_open(device, &handle);
     if (result < 0) {
+        // Log at debug level because it is expected that some non-Android USB
+        // devices present on the computer require special permissions
+        LOGD("Open USB device %04" PRIx16 ":%04" PRIx16 ": libusb error: %s",
+             desc.idVendor, desc.idProduct, libusb_strerror(result));
         return false;
     }