Extract String literal to static constant

This commit is contained in:
Romain Vimont 2019-10-17 22:11:39 +02:00
parent bab9361948
commit 5b7a0cd8e9

View file

@ -9,6 +9,9 @@ import java.lang.reflect.InvocationTargetException;
import java.lang.reflect.Method; import java.lang.reflect.Method;
public class ClipboardManager { public class ClipboardManager {
private static final String PACKAGE_NAME = "com.android.shell";
private final IInterface manager; private final IInterface manager;
private Method getPrimaryClipMethod; private Method getPrimaryClipMethod;
private Method setPrimaryClipMethod; private Method setPrimaryClipMethod;
@ -45,7 +48,7 @@ public class ClipboardManager {
return null; return null;
} }
try { try {
ClipData clipData = (ClipData) method.invoke(manager, "com.android.shell"); ClipData clipData = (ClipData) method.invoke(manager, PACKAGE_NAME);
if (clipData == null || clipData.getItemCount() == 0) { if (clipData == null || clipData.getItemCount() == 0) {
return null; return null;
} }
@ -63,7 +66,7 @@ public class ClipboardManager {
} }
ClipData clipData = ClipData.newPlainText(null, text); ClipData clipData = ClipData.newPlainText(null, text);
try { try {
method.invoke(manager, clipData, "com.android.shell"); method.invoke(manager, clipData, PACKAGE_NAME);
} catch (InvocationTargetException | IllegalAccessException e) { } catch (InvocationTargetException | IllegalAccessException e) {
Ln.e("Could not invoke " + method.getName(), e); Ln.e("Could not invoke " + method.getName(), e);
} }