Android/scrcpy
1
0
Fork 0
Code Issues Pull requests Projects Releases 1 Packages Wiki Activity

Check empty string before strtol()

Browse source 
There is no need to call strtol() if the input string is empty.
This commit is contained in:
Romain Vimont 2018-02-01 16:31:59 +01:00
parent 3bc63708b4
commit 7fe7bbf58c
1 changed files with 10 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
app/src/main.c
View file

@ -65,8 +65,12 @@ static int parse_args(struct args *args, int argc, char *argv[]) {
} }
case 'p': { case 'p': {
char *endptr; char *endptr;
if (*optarg == '\0') {
SDL_LogError(SDL_LOG_CATEGORY_APPLICATION, "Invalid port parameter is empty");
return -1;
}
long value = strtol(optarg, &endptr, 0); long value = strtol(optarg, &endptr, 0);
if (*optarg == '\0' || *endptr != '\0') { if (*endptr != '\0') {
SDL_LogError(SDL_LOG_CATEGORY_APPLICATION, "Invalid port: %s", optarg); SDL_LogError(SDL_LOG_CATEGORY_APPLICATION, "Invalid port: %s", optarg);
return -1; return -1;
} }
@ -79,8 +83,12 @@ static int parse_args(struct args *args, int argc, char *argv[]) {
} }
case 'm': { case 'm': {
char *endptr; char *endptr;
if (*optarg == '\0') {
SDL_LogError(SDL_LOG_CATEGORY_APPLICATION, "Max size parameter is empty");
return -1;
}
long value = strtol(optarg, &endptr, 0); long value = strtol(optarg, &endptr, 0);
if (*optarg == '\0' || *endptr != '\0') { if (*endptr != '\0') {
SDL_LogError(SDL_LOG_CATEGORY_APPLICATION, "Invalid max size: %s", optarg); SDL_LogError(SDL_LOG_CATEGORY_APPLICATION, "Invalid max size: %s", optarg);
return -1; return -1;
} }