Android/scrcpy
1
0
Fork 0
Code Issues Pull requests Projects Releases 1 Packages Wiki Activity

Fix clipboard paste condition

Browse source 
To avoid possible copy-paste loops between the computer and the device,
the device clipboard is not set if it already contains the expected
content.

But the condition was wrong: it was not set also if it was empty.

Refs 1223a72eb8
Fixes #1658 <https://github.com/Genymobile/scrcpy/issues/1658>
This commit is contained in:
Romain Vimont 2020-08-10 13:15:44 +02:00
parent 38940ffe89
commit 95f1ea0d80
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
server/src/main/java/com/genymobile/scrcpy/Device.java
View file

@ -223,7 +223,7 @@ public final class Device {
} }
String currentClipboard = getClipboardText(); String currentClipboard = getClipboardText();
if (currentClipboard == null || currentClipboard.equals(text)) { if (currentClipboard != null && currentClipboard.equals(text)) {
// The clipboard already contains the requested text. // The clipboard already contains the requested text.
// Since pasting text from the computer involves setting the device clipboard, it could be set twice on a copy-paste. This would cause // Since pasting text from the computer involves setting the device clipboard, it could be set twice on a copy-paste. This would cause
// the clipboard listeners to be notified twice, and that would flood the Android keyboard clipboard history. To workaround this // the clipboard listeners to be notified twice, and that would flood the Android keyboard clipboard history. To workaround this