Android/scrcpy
1
0
Fork 0
Code Issues Pull requests Projects Releases 1 Packages Wiki Activity

Refactor command line checks

Browse source 
Several checks are performed when opts->record_filename is not NULL.
Group them in a single block.

PR #3978 <https://github.com/Genymobile/scrcpy/pull/3978>
This commit is contained in:
Romain Vimont 2023-05-07 12:22:01 +02:00
parent be86e14e05
commit 98f4f4e68a
1 changed files with 12 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

22
app/src/cli.c
View file

@ -1959,21 +1959,23 @@ parse_args_with_getopt(struct scrcpy_cli_args *args, int argc, char *argv[],
return false; return false;
} }
if (opts->record_filename && !opts->record_format) { if (opts->record_filename) {
opts->record_format = guess_record_format(opts->record_filename);
if (!opts->record_format) { if (!opts->record_format) {
LOGE("No format specified for \"%s\" " opts->record_format = guess_record_format(opts->record_filename);
"(try with --record-format=mkv)", if (!opts->record_format) {
opts->record_filename); LOGE("No format specified for \"%s\" "
"(try with --record-format=mkv)",
opts->record_filename);
return false;
}
}
if (opts->audio_codec == SC_CODEC_RAW) {
LOGW("Recording does not support RAW audio codec");
return false; return false;
} }
} }
if (opts->record_filename && opts->audio_codec == SC_CODEC_RAW) {
LOGW("Recording does not support RAW audio codec");
return false;
}
if (opts->audio_codec == SC_CODEC_RAW) { if (opts->audio_codec == SC_CODEC_RAW) {
if (opts->audio_bit_rate) { if (opts->audio_bit_rate) {
LOGW("--audio-bit-rate is ignored for raw audio codec"); LOGW("--audio-bit-rate is ignored for raw audio codec");