From d950383b729f93d4da84e65013b4c78caddf6d68 Mon Sep 17 00:00:00 2001 From: Romain Vimont Date: Sun, 8 Dec 2019 21:35:19 +0100 Subject: [PATCH] Move command-line parsing to a separate file --- app/meson.build | 1 + app/src/cli.c | 525 +++++++++++++++++++++++++++++++++++++++++++++++ app/src/cli.h | 21 ++ app/src/main.c | 531 +----------------------------------------------- 4 files changed, 551 insertions(+), 527 deletions(-) create mode 100644 app/src/cli.c create mode 100644 app/src/cli.h diff --git a/app/meson.build b/app/meson.build index 332407c1..3e8d6063 100644 --- a/app/meson.build +++ b/app/meson.build @@ -1,5 +1,6 @@ src = [ 'src/main.c', + 'src/cli.c', 'src/command.c', 'src/control_msg.c', 'src/controller.c', diff --git a/app/src/cli.c b/app/src/cli.c new file mode 100644 index 00000000..a219895b --- /dev/null +++ b/app/src/cli.c @@ -0,0 +1,525 @@ +#include "cli.h" + +#include +#include +#include + +#include "config.h" +#include "recorder.h" +#include "util/log.h" +#include "util/str_util.h" + +void +scrcpy_print_usage(const char *arg0) { +#ifdef __APPLE__ +# define CTRL_OR_CMD "Cmd" +#else +# define CTRL_OR_CMD "Ctrl" +#endif + fprintf(stderr, + "Usage: %s [options]\n" + "\n" + "Options:\n" + "\n" + " --always-on-top\n" + " Make scrcpy window always on top (above other windows).\n" + "\n" + " -b, --bit-rate value\n" + " Encode the video at the given bit-rate, expressed in bits/s.\n" + " Unit suffixes are supported: 'K' (x1000) and 'M' (x1000000).\n" + " Default is %d.\n" + "\n" + " --crop width:height:x:y\n" + " Crop the device screen on the server.\n" + " The values are expressed in the device natural orientation\n" + " (typically, portrait for a phone, landscape for a tablet).\n" + " Any --max-size value is computed on the cropped size.\n" + "\n" + " -f, --fullscreen\n" + " Start in fullscreen.\n" + "\n" + " -h, --help\n" + " Print this help.\n" + "\n" + " --max-fps value\n" + " Limit the frame rate of screen capture (only supported on\n" + " devices with Android >= 10).\n" + "\n" + " -m, --max-size value\n" + " Limit both the width and height of the video to value. The\n" + " other dimension is computed so that the device aspect-ratio\n" + " is preserved.\n" + " Default is %d%s.\n" + "\n" + " -n, --no-control\n" + " Disable device control (mirror the device in read-only).\n" + "\n" + " -N, --no-display\n" + " Do not display device (only when screen recording is\n" + " enabled).\n" + "\n" + " -p, --port port\n" + " Set the TCP port the client listens on.\n" + " Default is %d.\n" + "\n" + " --prefer-text\n" + " Inject alpha characters and space as text events instead of\n" + " key events.\n" + " This avoids issues when combining multiple keys to enter a\n" + " special character, but breaks the expected behavior of alpha\n" + " keys in games (typically WASD).\n" + "\n" + " --push-target path\n" + " Set the target directory for pushing files to the device by\n" + " drag & drop. It is passed as-is to \"adb push\".\n" + " Default is \"/sdcard/\".\n" + "\n" + " -r, --record file.mp4\n" + " Record screen to file.\n" + " The format is determined by the --record-format option if\n" + " set, or by the file extension (.mp4 or .mkv).\n" + "\n" + " --record-format format\n" + " Force recording format (either mp4 or mkv).\n" + "\n" + " --render-expired-frames\n" + " By default, to minimize latency, scrcpy always renders the\n" + " last available decoded frame, and drops any previous ones.\n" + " This flag forces to render all frames, at a cost of a\n" + " possible increased latency.\n" + "\n" + " -s, --serial serial\n" + " The device serial number. Mandatory only if several devices\n" + " are connected to adb.\n" + "\n" + " -S, --turn-screen-off\n" + " Turn the device screen off immediately.\n" + "\n" + " -t, --show-touches\n" + " Enable \"show touches\" on start, disable on quit.\n" + " It only shows physical touches (not clicks from scrcpy).\n" + "\n" + " -v, --version\n" + " Print the version of scrcpy.\n" + "\n" + " --window-borderless\n" + " Disable window decorations (display borderless window).\n" + "\n" + " --window-title text\n" + " Set a custom window title.\n" + "\n" + " --window-x value\n" + " Set the initial window horizontal position.\n" + " Default is -1 (automatic).\n" + "\n" + " --window-y value\n" + " Set the initial window vertical position.\n" + " Default is -1 (automatic).\n" + "\n" + " --window-width value\n" + " Set the initial window width.\n" + " Default is 0 (automatic).\n" + "\n" + " --window-height value\n" + " Set the initial window width.\n" + " Default is 0 (automatic).\n" + "\n" + "Shortcuts:\n" + "\n" + " " CTRL_OR_CMD "+f\n" + " switch fullscreen mode\n" + "\n" + " " CTRL_OR_CMD "+g\n" + " resize window to 1:1 (pixel-perfect)\n" + "\n" + " " CTRL_OR_CMD "+x\n" + " Double-click on black borders\n" + " resize window to remove black borders\n" + "\n" + " Ctrl+h\n" + " Middle-click\n" + " click on HOME\n" + "\n" + " " CTRL_OR_CMD "+b\n" + " " CTRL_OR_CMD "+Backspace\n" + " Right-click (when screen is on)\n" + " click on BACK\n" + "\n" + " " CTRL_OR_CMD "+s\n" + " click on APP_SWITCH\n" + "\n" + " Ctrl+m\n" + " click on MENU\n" + "\n" + " " CTRL_OR_CMD "+Up\n" + " click on VOLUME_UP\n" + "\n" + " " CTRL_OR_CMD "+Down\n" + " click on VOLUME_DOWN\n" + "\n" + " " CTRL_OR_CMD "+p\n" + " click on POWER (turn screen on/off)\n" + "\n" + " Right-click (when screen is off)\n" + " power on\n" + "\n" + " " CTRL_OR_CMD "+o\n" + " turn device screen off (keep mirroring)\n" + "\n" + " " CTRL_OR_CMD "+r\n" + " rotate device screen\n" + "\n" + " " CTRL_OR_CMD "+n\n" + " expand notification panel\n" + "\n" + " " CTRL_OR_CMD "+Shift+n\n" + " collapse notification panel\n" + "\n" + " " CTRL_OR_CMD "+c\n" + " copy device clipboard to computer\n" + "\n" + " " CTRL_OR_CMD "+v\n" + " paste computer clipboard to device\n" + "\n" + " " CTRL_OR_CMD "+Shift+v\n" + " copy computer clipboard to device\n" + "\n" + " " CTRL_OR_CMD "+i\n" + " enable/disable FPS counter (print frames/second in logs)\n" + "\n" + " Drag & drop APK file\n" + " install APK from computer\n" + "\n", + arg0, + DEFAULT_BIT_RATE, + DEFAULT_MAX_SIZE, DEFAULT_MAX_SIZE ? "" : " (unlimited)", + DEFAULT_LOCAL_PORT); +} + +static bool +parse_integer_arg(const char *s, long *out, bool accept_suffix, long min, + long max, const char *name) { + long value; + bool ok; + if (accept_suffix) { + ok = parse_integer_with_suffix(s, &value); + } else { + ok = parse_integer(s, &value); + } + if (!ok) { + LOGE("Could not parse %s: %s", name, s); + return false; + } + + if (value < min || value > max) { + LOGE("Could not parse %s: value (%ld) out-of-range (%ld; %ld)", + name, value, min, max); + return false; + } + + *out = value; + return true; +} + +static bool +parse_bit_rate(const char *s, uint32_t *bit_rate) { + long value; + bool ok = parse_integer_arg(s, &value, true, 0, 0xFFFFFFFF, "bit-rate"); + if (!ok) { + return false; + } + + *bit_rate = (uint32_t) value; + return true; +} + +static bool +parse_max_size(char *s, uint16_t *max_size) { + long value; + bool ok = parse_integer_arg(s, &value, false, 0, 0xFFFF, "max size"); + if (!ok) { + return false; + } + + *max_size = (uint16_t) value; + return true; +} + +static bool +parse_max_fps(const char *s, uint16_t *max_fps) { + long value; + bool ok = parse_integer_arg(s, &value, false, 0, 1000, "max fps"); + if (!ok) { + return false; + } + + *max_fps = (uint16_t) value; + return true; +} + +static bool +parse_window_position(char *s, int16_t *position) { + long value; + bool ok = parse_integer_arg(s, &value, false, -1, 0x7FFF, + "window position"); + if (!ok) { + return false; + } + + *position = (int16_t) value; + return true; +} + +static bool +parse_window_dimension(char *s, uint16_t *dimension) { + long value; + bool ok = parse_integer_arg(s, &value, false, 0, 0xFFFF, + "window dimension"); + if (!ok) { + return false; + } + + *dimension = (uint16_t) value; + return true; +} + +static bool +parse_port(char *s, uint16_t *port) { + long value; + bool ok = parse_integer_arg(s, &value, false, 0, 0xFFFF, "port"); + if (!ok) { + return false; + } + + *port = (uint16_t) value; + return true; +} + +static bool +parse_record_format(const char *optarg, enum recorder_format *format) { + if (!strcmp(optarg, "mp4")) { + *format = RECORDER_FORMAT_MP4; + return true; + } + if (!strcmp(optarg, "mkv")) { + *format = RECORDER_FORMAT_MKV; + return true; + } + LOGE("Unsupported format: %s (expected mp4 or mkv)", optarg); + return false; +} + +static enum recorder_format +guess_record_format(const char *filename) { + size_t len = strlen(filename); + if (len < 4) { + return 0; + } + const char *ext = &filename[len - 4]; + if (!strcmp(ext, ".mp4")) { + return RECORDER_FORMAT_MP4; + } + if (!strcmp(ext, ".mkv")) { + return RECORDER_FORMAT_MKV; + } + return 0; +} + +#define OPT_RENDER_EXPIRED_FRAMES 1000 +#define OPT_WINDOW_TITLE 1001 +#define OPT_PUSH_TARGET 1002 +#define OPT_ALWAYS_ON_TOP 1003 +#define OPT_CROP 1004 +#define OPT_RECORD_FORMAT 1005 +#define OPT_PREFER_TEXT 1006 +#define OPT_WINDOW_X 1007 +#define OPT_WINDOW_Y 1008 +#define OPT_WINDOW_WIDTH 1009 +#define OPT_WINDOW_HEIGHT 1010 +#define OPT_WINDOW_BORDERLESS 1011 +#define OPT_MAX_FPS 1012 + +bool +scrcpy_parse_args(struct scrcpy_cli_args *args, int argc, char *argv[]) { + static const struct option long_options[] = { + {"always-on-top", no_argument, NULL, OPT_ALWAYS_ON_TOP}, + {"bit-rate", required_argument, NULL, 'b'}, + {"crop", required_argument, NULL, OPT_CROP}, + {"fullscreen", no_argument, NULL, 'f'}, + {"help", no_argument, NULL, 'h'}, + {"max-fps", required_argument, NULL, OPT_MAX_FPS}, + {"max-size", required_argument, NULL, 'm'}, + {"no-control", no_argument, NULL, 'n'}, + {"no-display", no_argument, NULL, 'N'}, + {"port", required_argument, NULL, 'p'}, + {"push-target", required_argument, NULL, OPT_PUSH_TARGET}, + {"record", required_argument, NULL, 'r'}, + {"record-format", required_argument, NULL, OPT_RECORD_FORMAT}, + {"render-expired-frames", no_argument, NULL, + OPT_RENDER_EXPIRED_FRAMES}, + {"serial", required_argument, NULL, 's'}, + {"show-touches", no_argument, NULL, 't'}, + {"turn-screen-off", no_argument, NULL, 'S'}, + {"prefer-text", no_argument, NULL, OPT_PREFER_TEXT}, + {"version", no_argument, NULL, 'v'}, + {"window-title", required_argument, NULL, OPT_WINDOW_TITLE}, + {"window-x", required_argument, NULL, OPT_WINDOW_X}, + {"window-y", required_argument, NULL, OPT_WINDOW_Y}, + {"window-width", required_argument, NULL, OPT_WINDOW_WIDTH}, + {"window-height", required_argument, NULL, OPT_WINDOW_HEIGHT}, + {"window-borderless", no_argument, NULL, + OPT_WINDOW_BORDERLESS}, + {NULL, 0, NULL, 0 }, + }; + + struct scrcpy_options *opts = &args->opts; + + int c; + while ((c = getopt_long(argc, argv, "b:c:fF:hm:nNp:r:s:StTv", long_options, + NULL)) != -1) { + switch (c) { + case 'b': + if (!parse_bit_rate(optarg, &opts->bit_rate)) { + return false; + } + break; + case 'c': + LOGW("Deprecated option -c. Use --crop instead."); + // fall through + case OPT_CROP: + opts->crop = optarg; + break; + case 'f': + opts->fullscreen = true; + break; + case 'F': + LOGW("Deprecated option -F. Use --record-format instead."); + // fall through + case OPT_RECORD_FORMAT: + if (!parse_record_format(optarg, &opts->record_format)) { + return false; + } + break; + case 'h': + args->help = true; + break; + case OPT_MAX_FPS: + if (!parse_max_fps(optarg, &opts->max_fps)) { + return false; + } + break; + case 'm': + if (!parse_max_size(optarg, &opts->max_size)) { + return false; + } + break; + case 'n': + opts->control = false; + break; + case 'N': + opts->display = false; + break; + case 'p': + if (!parse_port(optarg, &opts->port)) { + return false; + } + break; + case 'r': + opts->record_filename = optarg; + break; + case 's': + opts->serial = optarg; + break; + case 'S': + opts->turn_screen_off = true; + break; + case 't': + opts->show_touches = true; + break; + case 'T': + LOGW("Deprecated option -T. Use --always-on-top instead."); + // fall through + case OPT_ALWAYS_ON_TOP: + opts->always_on_top = true; + break; + case 'v': + args->version = true; + break; + case OPT_RENDER_EXPIRED_FRAMES: + opts->render_expired_frames = true; + break; + case OPT_WINDOW_TITLE: + opts->window_title = optarg; + break; + case OPT_WINDOW_X: + if (!parse_window_position(optarg, &opts->window_x)) { + return false; + } + break; + case OPT_WINDOW_Y: + if (!parse_window_position(optarg, &opts->window_y)) { + return false; + } + break; + case OPT_WINDOW_WIDTH: + if (!parse_window_dimension(optarg, &opts->window_width)) { + return false; + } + break; + case OPT_WINDOW_HEIGHT: + if (!parse_window_dimension(optarg, &opts->window_height)) { + return false; + } + break; + case OPT_WINDOW_BORDERLESS: + opts->window_borderless = true; + break; + case OPT_PUSH_TARGET: + opts->push_target = optarg; + break; + case OPT_PREFER_TEXT: + opts->prefer_text = true; + break; + default: + // getopt prints the error message on stderr + return false; + } + } + + if (!opts->display && !opts->record_filename) { + LOGE("-N/--no-display requires screen recording (-r/--record)"); + return false; + } + + if (!opts->display && opts->fullscreen) { + LOGE("-f/--fullscreen-window is incompatible with -N/--no-display"); + return false; + } + + int index = optind; + if (index < argc) { + LOGE("Unexpected additional argument: %s", argv[index]); + return false; + } + + if (opts->record_format && !opts->record_filename) { + LOGE("Record format specified without recording"); + return false; + } + + if (opts->record_filename && !opts->record_format) { + opts->record_format = guess_record_format(opts->record_filename); + if (!opts->record_format) { + LOGE("No format specified for \"%s\" (try with -F mkv)", + opts->record_filename); + return false; + } + } + + if (!opts->control && opts->turn_screen_off) { + LOGE("Could not request to turn screen off if control is disabled"); + return false; + } + + return true; +} diff --git a/app/src/cli.h b/app/src/cli.h new file mode 100644 index 00000000..2e2bfe93 --- /dev/null +++ b/app/src/cli.h @@ -0,0 +1,21 @@ +#ifndef SCRCPY_CLI_H +#define SCRCPY_CLI_H + +#include + +#include "config.h" +#include "scrcpy.h" + +struct scrcpy_cli_args { + struct scrcpy_options opts; + bool help; + bool version; +}; + +void +scrcpy_print_usage(const char *arg0); + +bool +scrcpy_parse_args(struct scrcpy_cli_args *args, int argc, char *argv[]); + +#endif diff --git a/app/src/main.c b/app/src/main.c index 53ef253e..43e2cc04 100644 --- a/app/src/main.c +++ b/app/src/main.c @@ -1,210 +1,15 @@ #include "scrcpy.h" -#include #include -#include #include #include #define SDL_MAIN_HANDLED // avoid link error on Linux Windows Subsystem #include #include "config.h" +#include "cli.h" #include "compat.h" -#include "recorder.h" #include "util/log.h" -#include "util/str_util.h" - -struct args { - struct scrcpy_options opts; - bool help; - bool version; -}; - -static void usage(const char *arg0) { -#ifdef __APPLE__ -# define CTRL_OR_CMD "Cmd" -#else -# define CTRL_OR_CMD "Ctrl" -#endif - fprintf(stderr, - "Usage: %s [options]\n" - "\n" - "Options:\n" - "\n" - " --always-on-top\n" - " Make scrcpy window always on top (above other windows).\n" - "\n" - " -b, --bit-rate value\n" - " Encode the video at the given bit-rate, expressed in bits/s.\n" - " Unit suffixes are supported: 'K' (x1000) and 'M' (x1000000).\n" - " Default is %d.\n" - "\n" - " --crop width:height:x:y\n" - " Crop the device screen on the server.\n" - " The values are expressed in the device natural orientation\n" - " (typically, portrait for a phone, landscape for a tablet).\n" - " Any --max-size value is computed on the cropped size.\n" - "\n" - " -f, --fullscreen\n" - " Start in fullscreen.\n" - "\n" - " -h, --help\n" - " Print this help.\n" - "\n" - " --max-fps value\n" - " Limit the frame rate of screen capture (only supported on\n" - " devices with Android >= 10).\n" - "\n" - " -m, --max-size value\n" - " Limit both the width and height of the video to value. The\n" - " other dimension is computed so that the device aspect-ratio\n" - " is preserved.\n" - " Default is %d%s.\n" - "\n" - " -n, --no-control\n" - " Disable device control (mirror the device in read-only).\n" - "\n" - " -N, --no-display\n" - " Do not display device (only when screen recording is\n" - " enabled).\n" - "\n" - " -p, --port port\n" - " Set the TCP port the client listens on.\n" - " Default is %d.\n" - "\n" - " --prefer-text\n" - " Inject alpha characters and space as text events instead of\n" - " key events.\n" - " This avoids issues when combining multiple keys to enter a\n" - " special character, but breaks the expected behavior of alpha\n" - " keys in games (typically WASD).\n" - "\n" - " --push-target path\n" - " Set the target directory for pushing files to the device by\n" - " drag & drop. It is passed as-is to \"adb push\".\n" - " Default is \"/sdcard/\".\n" - "\n" - " -r, --record file.mp4\n" - " Record screen to file.\n" - " The format is determined by the --record-format option if\n" - " set, or by the file extension (.mp4 or .mkv).\n" - "\n" - " --record-format format\n" - " Force recording format (either mp4 or mkv).\n" - "\n" - " --render-expired-frames\n" - " By default, to minimize latency, scrcpy always renders the\n" - " last available decoded frame, and drops any previous ones.\n" - " This flag forces to render all frames, at a cost of a\n" - " possible increased latency.\n" - "\n" - " -s, --serial serial\n" - " The device serial number. Mandatory only if several devices\n" - " are connected to adb.\n" - "\n" - " -S, --turn-screen-off\n" - " Turn the device screen off immediately.\n" - "\n" - " -t, --show-touches\n" - " Enable \"show touches\" on start, disable on quit.\n" - " It only shows physical touches (not clicks from scrcpy).\n" - "\n" - " -v, --version\n" - " Print the version of scrcpy.\n" - "\n" - " --window-borderless\n" - " Disable window decorations (display borderless window).\n" - "\n" - " --window-title text\n" - " Set a custom window title.\n" - "\n" - " --window-x value\n" - " Set the initial window horizontal position.\n" - " Default is -1 (automatic).\n" - "\n" - " --window-y value\n" - " Set the initial window vertical position.\n" - " Default is -1 (automatic).\n" - "\n" - " --window-width value\n" - " Set the initial window width.\n" - " Default is 0 (automatic).\n" - "\n" - " --window-height value\n" - " Set the initial window width.\n" - " Default is 0 (automatic).\n" - "\n" - "Shortcuts:\n" - "\n" - " " CTRL_OR_CMD "+f\n" - " switch fullscreen mode\n" - "\n" - " " CTRL_OR_CMD "+g\n" - " resize window to 1:1 (pixel-perfect)\n" - "\n" - " " CTRL_OR_CMD "+x\n" - " Double-click on black borders\n" - " resize window to remove black borders\n" - "\n" - " Ctrl+h\n" - " Middle-click\n" - " click on HOME\n" - "\n" - " " CTRL_OR_CMD "+b\n" - " " CTRL_OR_CMD "+Backspace\n" - " Right-click (when screen is on)\n" - " click on BACK\n" - "\n" - " " CTRL_OR_CMD "+s\n" - " click on APP_SWITCH\n" - "\n" - " Ctrl+m\n" - " click on MENU\n" - "\n" - " " CTRL_OR_CMD "+Up\n" - " click on VOLUME_UP\n" - "\n" - " " CTRL_OR_CMD "+Down\n" - " click on VOLUME_DOWN\n" - "\n" - " " CTRL_OR_CMD "+p\n" - " click on POWER (turn screen on/off)\n" - "\n" - " Right-click (when screen is off)\n" - " power on\n" - "\n" - " " CTRL_OR_CMD "+o\n" - " turn device screen off (keep mirroring)\n" - "\n" - " " CTRL_OR_CMD "+r\n" - " rotate device screen\n" - "\n" - " " CTRL_OR_CMD "+n\n" - " expand notification panel\n" - "\n" - " " CTRL_OR_CMD "+Shift+n\n" - " collapse notification panel\n" - "\n" - " " CTRL_OR_CMD "+c\n" - " copy device clipboard to computer\n" - "\n" - " " CTRL_OR_CMD "+v\n" - " paste computer clipboard to device\n" - "\n" - " " CTRL_OR_CMD "+Shift+v\n" - " copy computer clipboard to device\n" - "\n" - " " CTRL_OR_CMD "+i\n" - " enable/disable FPS counter (print frames/second in logs)\n" - "\n" - " Drag & drop APK file\n" - " install APK from computer\n" - "\n", - arg0, - DEFAULT_BIT_RATE, - DEFAULT_MAX_SIZE, DEFAULT_MAX_SIZE ? "" : " (unlimited)", - DEFAULT_LOCAL_PORT); -} static void print_version(void) { @@ -224,334 +29,6 @@ print_version(void) { LIBAVUTIL_VERSION_MICRO); } -static bool -parse_integer_arg(const char *s, long *out, bool accept_suffix, long min, - long max, const char *name) { - long value; - bool ok; - if (accept_suffix) { - ok = parse_integer_with_suffix(s, &value); - } else { - ok = parse_integer(s, &value); - } - if (!ok) { - LOGE("Could not parse %s: %s", name, s); - return false; - } - - if (value < min || value > max) { - LOGE("Could not parse %s: value (%ld) out-of-range (%ld; %ld)", - name, value, min, max); - return false; - } - - *out = value; - return true; -} - -static bool -parse_bit_rate(const char *s, uint32_t *bit_rate) { - long value; - bool ok = parse_integer_arg(s, &value, true, 0, 0xFFFF, "bit-rate"); - if (!ok) { - return false; - } - - *bit_rate = (uint32_t) value; - return true; -} - -static bool -parse_max_size(char *s, uint16_t *max_size) { - long value; - bool ok = parse_integer_arg(s, &value, false, 0, 0xFFFF, "max size"); - if (!ok) { - return false; - } - - *max_size = (uint16_t) value; - return true; -} - -static bool -parse_max_fps(const char *s, uint16_t *max_fps) { - long value; - bool ok = parse_integer_arg(s, &value, false, 0, 1000, "max fps"); - if (!ok) { - return false; - } - - *max_fps = (uint16_t) value; - return true; -} - -static bool -parse_window_position(char *s, int16_t *position) { - long value; - bool ok = parse_integer_arg(s, &value, false, -1, 0x7FFF, - "window position"); - if (!ok) { - return false; - } - - *position = (int16_t) value; - return true; -} - -static bool -parse_window_dimension(char *s, uint16_t *dimension) { - long value; - bool ok = parse_integer_arg(s, &value, false, 0, 0xFFFF, - "window dimension"); - if (!ok) { - return false; - } - - *dimension = (uint16_t) value; - return true; -} - -static bool -parse_port(char *s, uint16_t *port) { - long value; - bool ok = parse_integer_arg(s, &value, false, 0, 0xFFFF, "port"); - if (!ok) { - return false; - } - - *port = (uint16_t) value; - return true; -} - -static bool -parse_record_format(const char *optarg, enum recorder_format *format) { - if (!strcmp(optarg, "mp4")) { - *format = RECORDER_FORMAT_MP4; - return true; - } - if (!strcmp(optarg, "mkv")) { - *format = RECORDER_FORMAT_MKV; - return true; - } - LOGE("Unsupported format: %s (expected mp4 or mkv)", optarg); - return false; -} - -static enum recorder_format -guess_record_format(const char *filename) { - size_t len = strlen(filename); - if (len < 4) { - return 0; - } - const char *ext = &filename[len - 4]; - if (!strcmp(ext, ".mp4")) { - return RECORDER_FORMAT_MP4; - } - if (!strcmp(ext, ".mkv")) { - return RECORDER_FORMAT_MKV; - } - return 0; -} - -#define OPT_RENDER_EXPIRED_FRAMES 1000 -#define OPT_WINDOW_TITLE 1001 -#define OPT_PUSH_TARGET 1002 -#define OPT_ALWAYS_ON_TOP 1003 -#define OPT_CROP 1004 -#define OPT_RECORD_FORMAT 1005 -#define OPT_PREFER_TEXT 1006 -#define OPT_WINDOW_X 1007 -#define OPT_WINDOW_Y 1008 -#define OPT_WINDOW_WIDTH 1009 -#define OPT_WINDOW_HEIGHT 1010 -#define OPT_WINDOW_BORDERLESS 1011 -#define OPT_MAX_FPS 1012 - -static bool -parse_args(struct args *args, int argc, char *argv[]) { - static const struct option long_options[] = { - {"always-on-top", no_argument, NULL, OPT_ALWAYS_ON_TOP}, - {"bit-rate", required_argument, NULL, 'b'}, - {"crop", required_argument, NULL, OPT_CROP}, - {"fullscreen", no_argument, NULL, 'f'}, - {"help", no_argument, NULL, 'h'}, - {"max-fps", required_argument, NULL, OPT_MAX_FPS}, - {"max-size", required_argument, NULL, 'm'}, - {"no-control", no_argument, NULL, 'n'}, - {"no-display", no_argument, NULL, 'N'}, - {"port", required_argument, NULL, 'p'}, - {"push-target", required_argument, NULL, OPT_PUSH_TARGET}, - {"record", required_argument, NULL, 'r'}, - {"record-format", required_argument, NULL, OPT_RECORD_FORMAT}, - {"render-expired-frames", no_argument, NULL, - OPT_RENDER_EXPIRED_FRAMES}, - {"serial", required_argument, NULL, 's'}, - {"show-touches", no_argument, NULL, 't'}, - {"turn-screen-off", no_argument, NULL, 'S'}, - {"prefer-text", no_argument, NULL, OPT_PREFER_TEXT}, - {"version", no_argument, NULL, 'v'}, - {"window-title", required_argument, NULL, OPT_WINDOW_TITLE}, - {"window-x", required_argument, NULL, OPT_WINDOW_X}, - {"window-y", required_argument, NULL, OPT_WINDOW_Y}, - {"window-width", required_argument, NULL, OPT_WINDOW_WIDTH}, - {"window-height", required_argument, NULL, OPT_WINDOW_HEIGHT}, - {"window-borderless", no_argument, NULL, - OPT_WINDOW_BORDERLESS}, - {NULL, 0, NULL, 0 }, - }; - - struct scrcpy_options *opts = &args->opts; - - int c; - while ((c = getopt_long(argc, argv, "b:c:fF:hm:nNp:r:s:StTv", long_options, - NULL)) != -1) { - switch (c) { - case 'b': - if (!parse_bit_rate(optarg, &opts->bit_rate)) { - return false; - } - break; - case 'c': - LOGW("Deprecated option -c. Use --crop instead."); - // fall through - case OPT_CROP: - opts->crop = optarg; - break; - case 'f': - opts->fullscreen = true; - break; - case 'F': - LOGW("Deprecated option -F. Use --record-format instead."); - // fall through - case OPT_RECORD_FORMAT: - if (!parse_record_format(optarg, &opts->record_format)) { - return false; - } - break; - case 'h': - args->help = true; - break; - case OPT_MAX_FPS: - if (!parse_max_fps(optarg, &opts->max_fps)) { - return false; - } - break; - case 'm': - if (!parse_max_size(optarg, &opts->max_size)) { - return false; - } - break; - case 'n': - opts->control = false; - break; - case 'N': - opts->display = false; - break; - case 'p': - if (!parse_port(optarg, &opts->port)) { - return false; - } - break; - case 'r': - opts->record_filename = optarg; - break; - case 's': - opts->serial = optarg; - break; - case 'S': - opts->turn_screen_off = true; - break; - case 't': - opts->show_touches = true; - break; - case 'T': - LOGW("Deprecated option -T. Use --always-on-top instead."); - // fall through - case OPT_ALWAYS_ON_TOP: - opts->always_on_top = true; - break; - case 'v': - args->version = true; - break; - case OPT_RENDER_EXPIRED_FRAMES: - opts->render_expired_frames = true; - break; - case OPT_WINDOW_TITLE: - opts->window_title = optarg; - break; - case OPT_WINDOW_X: - if (!parse_window_position(optarg, &opts->window_x)) { - return false; - } - break; - case OPT_WINDOW_Y: - if (!parse_window_position(optarg, &opts->window_y)) { - return false; - } - break; - case OPT_WINDOW_WIDTH: - if (!parse_window_dimension(optarg, &opts->window_width)) { - return false; - } - break; - case OPT_WINDOW_HEIGHT: - if (!parse_window_dimension(optarg, &opts->window_height)) { - return false; - } - break; - case OPT_WINDOW_BORDERLESS: - opts->window_borderless = true; - break; - case OPT_PUSH_TARGET: - opts->push_target = optarg; - break; - case OPT_PREFER_TEXT: - opts->prefer_text = true; - break; - default: - // getopt prints the error message on stderr - return false; - } - } - - if (!opts->display && !opts->record_filename) { - LOGE("-N/--no-display requires screen recording (-r/--record)"); - return false; - } - - if (!opts->display && opts->fullscreen) { - LOGE("-f/--fullscreen-window is incompatible with -N/--no-display"); - return false; - } - - int index = optind; - if (index < argc) { - LOGE("Unexpected additional argument: %s", argv[index]); - return false; - } - - if (opts->record_format && !opts->record_filename) { - LOGE("Record format specified without recording"); - return false; - } - - if (opts->record_filename && !opts->record_format) { - opts->record_format = guess_record_format(opts->record_filename); - if (!opts->record_format) { - LOGE("No format specified for \"%s\" (try with -F mkv)", - opts->record_filename); - return false; - } - } - - if (!opts->control && opts->turn_screen_off) { - LOGE("Could not request to turn screen off if control is disabled"); - return false; - } - - return true; -} - int main(int argc, char *argv[]) { #ifdef __WINDOWS__ @@ -560,18 +37,18 @@ main(int argc, char *argv[]) { setbuf(stdout, NULL); setbuf(stderr, NULL); #endif - struct args args = { + struct scrcpy_cli_args args = { .opts = SCRCPY_OPTIONS_DEFAULT, .help = false, .version = false, }; - if (!parse_args(&args, argc, argv)) { + if (!scrcpy_parse_args(&args, argc, argv)) { return 1; } if (args.help) { - usage(argv[0]); + scrcpy_print_usage(argv[0]); return 0; }