From fa9976366895c1adbfdbf98fb624107e71d4b24e Mon Sep 17 00:00:00 2001 From: Romain Vimont Date: Sun, 19 Feb 2023 20:06:30 +0100 Subject: [PATCH] Fix --encoder documentation Mention that it depends on the codec provided by --codec (which is not necessarily H264 anymore). --- app/data/zsh-completion/_scrcpy | 2 +- app/scrcpy.1 | 2 +- app/src/cli.c | 3 ++- 3 files changed, 4 insertions(+), 3 deletions(-) diff --git a/app/data/zsh-completion/_scrcpy b/app/data/zsh-completion/_scrcpy index c57111cc..961565e7 100644 --- a/app/data/zsh-completion/_scrcpy +++ b/app/data/zsh-completion/_scrcpy @@ -18,7 +18,7 @@ arguments=( '--display=[Specify the display id to mirror]' '--display-buffer=[Add a buffering delay \(in milliseconds\) before displaying]' {-e,--select-tcpip}'[Use TCP/IP device]' - '--encoder=[Use a specific MediaCodec encoder \(must be a H.264 encoder\)]' + '--encoder=[Use a specific MediaCodec encoder]' '--force-adb-forward[Do not attempt to use \"adb reverse\" to connect to the device]' '--forward-all-clicks[Forward clicks to device]' {-f,--fullscreen}'[Start in fullscreen]' diff --git a/app/scrcpy.1 b/app/scrcpy.1 index 8f028d7c..0f1147da 100644 --- a/app/scrcpy.1 +++ b/app/scrcpy.1 @@ -82,7 +82,7 @@ Also see \fB\-d\fR (\fB\-\-select\-usb\fR). .TP .BI "\-\-encoder " name -Use a specific MediaCodec encoder (must be a H.264 encoder). +Use a specific MediaCodec encoder (depending on the codec provided by \fB\-\-codec\fR). .TP .B \-\-force\-adb\-forward diff --git a/app/src/cli.c b/app/src/cli.c index 1851bad6..ab460732 100644 --- a/app/src/cli.c +++ b/app/src/cli.c @@ -175,7 +175,8 @@ static const struct sc_option options[] = { .longopt_id = OPT_ENCODER_NAME, .longopt = "encoder", .argdesc = "name", - .text = "Use a specific MediaCodec encoder (must be a H.264 encoder).", + .text = "Use a specific MediaCodec encoder (depending on the codec " + "provided by --codec).", }, { .longopt_id = OPT_FORCE_ADB_FORWARD,