Android/scrcpy
1
0
Fork 0
Code Issues Pull requests Projects Releases 1 Packages Wiki Activity
2034 commits 2 branches 1 tag 4.1 MiB
Commit graph

109 commits

Author SHA1 Message Date
Romain Vimont
6f38c6311b Remove sc_queue 
All uses have been replaced by VecDeque.
 2023-03-10 22:22:15 +01:00
Romain Vimont
338310677e Remove cbuf 
All uses have been replaced by VecDeque.
 2023-03-10 22:22:15 +01:00
Romain Vimont
33df484912 Introduce VecDeque 
Introduce a double-ended queue implemented with a growable ring buffer.

Inspired from the Rust VecDeque type:
<https://doc.rust-lang.org/std/collections/struct.VecDeque.html>
 2023-03-10 22:22:15 +01:00
Romain Vimont
b60a8aa657 Add two-step write feature to bytebuf 
If there is exactly one producer, then it can assume that the remaining
space in the buffer will only increase until it writes something.

This assumption may allow the producer to write to the buffer (up to a
known safe size) without any synchronization mechanism, thus allowing
to read and write different parts of the buffer in parallel.

The producer can then commit the write with a lock held, and update its
knowledge of the safe empty remaining space.

PR #3757 <https://github.com/Genymobile/scrcpy/pull/3757>
 2023-03-10 22:22:15 +01:00
Romain Vimont
20d41fdd7e Introduce bytebuf util 
Add a ring-buffer for bytes. It will be useful for audio buffering.

PR #3757 <https://github.com/Genymobile/scrcpy/pull/3757>
 2023-03-10 22:22:15 +01:00
Romain Vimont
9087e85c3f Rename --bit-rate to --video-bit-rate 
This prepares the introduction of --audio-bit-rate.

PR #3757 <https://github.com/Genymobile/scrcpy/pull/3757>
 2023-03-10 22:22:15 +01:00
Simon Chan
0afef0c634 Forward action button to device 
On click event, only the whole buttons state was passed to the device.
In addition, on ACTION_DOWN and ACTION_UP, pass the button associated to
the action.

Refs #3635 <https://github.com/Genymobile/scrcpy/issues/3635>

Co-authored-by: Romain Vimont <rom@rom1v.com>
Signed-off-by: Romain Vimont <rom@rom1v.com>
 2023-01-30 20:57:54 +01:00
Simon Chan
57056d078d Use precise scrolling values 
Since SDL 2.0.18, the amount scrolled horizontally or vertically is
exposed as a float (between 0 and 1). Forward a precise value to the
Android device when possible.

Refs <https://wiki.libsdl.org/SDL_MouseWheelEvent>
Fixes #3363 <https://github.com/Genymobile/scrcpy/issues/3363>
PR #3369 <https://github.com/Genymobile/scrcpy/pull/3369>

Signed-off-by: Romain Vimont <rom@rom1v.com>
 2022-08-28 15:23:08 +02:00
Romain Vimont
1f138aef41 Add conversion from float to fixed-point i16 
To encode float values between -1 and 1.

PR #3369 <https://github.com/Genymobile/scrcpy/pull/3369>
 2022-08-28 15:23:08 +02:00
Romain Vimont
1ab6c19486 Add unit test for float encoding 
PR #3369 <https://github.com/Genymobile/scrcpy/pull/3369>
 2022-08-28 15:23:08 +02:00
Romain Vimont
041cdf6cf5 Rename buffer_util.h to binary.h 
It will allow to expose more binary util functions not related to
buffers.

PR #3369 <https://github.com/Genymobile/scrcpy/pull/3369>
 2022-08-28 15:23:08 +02:00
Romain Vimont
b1d8c72780 Rename function to simplify 
For consistency with sc_adb_parse_device(), do not include "from_output"
in the function name.
 2022-06-09 15:02:42 +02:00
Romain Vimont
55e65fa270 Add missing return 0 in tests 2022-06-09 15:02:42 +02:00
Romain Vimont
69fb5f6ee1 Fix function declarations 
Add missing void in function parameters list.
 2022-06-09 15:02:42 +02:00
Romain Vimont
4b8cb042c4 Use vector for listing ADB devices 
This avoids the hardcoded maximum number of ADB devices detected (16).

Refs #3029 <https://github.com/Genymobile/scrcpy/pull/3029>
PR #3035 <https://github.com/Genymobile/scrcpy/pull/3035>

Co-authored-by: Daniel Ansorregui <d.ansorregui@samsung.com>
 2022-02-20 23:59:35 +01:00
Romain Vimont
c070723bc8 Add sc_vector 
Adapt vlc_vector [1], that I initially wrote while implementing the VLC
playlist [2].

Change the implementation to use "statement expressions" [3], which are
forbidden in VLC because "non-standard", but:
 - they are supported by gcc and clang;
 - they are already used in the scrcpy codebase;
 - they avoid implementation hacks (VLC_VECTOR_FAILFLAG_);
 - they allow a better API (sc_vector_index_of() may return the result
   without an output parameter).

PR #3035 <https://github.com/Genymobile/scrcpy/pull/3035>

[1]: 0857947aba/include/vlc_vector.h
[2]: https://blog.rom1v.com/2019/05/a-new-core-playlist-for-vlc-4
[3]: https://gcc.gnu.org/onlinedocs/gcc/Statement-Exprs.html
 2022-02-20 23:59:35 +01:00
Romain Vimont
6edf50d447 Remove fprintf() in tests 
It was committed by mistake.
 2022-02-18 19:34:54 +01:00
Romain Vimont
5c62f3419d Rename buffer util functions with sc_ prefix 2022-02-12 09:12:46 +01:00
Romain Vimont
4389de1c23 Add adb devices parser 
Add a parser of `adb device -l` output, to extract a list of devices
with their serial, state and model.

PR #3005 <https://github.com/Genymobile/scrcpy/pull/3005>
 2022-02-09 09:56:25 +01:00
Romain Vimont
137d2c9791 Remove confusing sc_str_truncate() 
This util function was error-prone:
 - it accepted a buffer as parameter (not necessarily a NUL-terminated
   string) and its length (including the NUL char, if any);
 - it wrote '\0' over the last character of the buffer, so the last
   character was lost if the buffer was not a NUL-terminated string, and
   even worse, it caused undefined behavior if the length was empty;
 - it returned the length of the resulting NUL-terminated string,
   which was inconsistent with the input buffer length.

In addition, it was not necessarily optimal:
 - it wrote '\0' twice;
 - it required to know the buffer length, that is the input string
   length + 1, in advance.

Remove this function, and let the client use strcspn() manually.
 2022-02-06 14:39:51 +01:00
Romain Vimont
5d6bd8f9cd Fix adb device ip parsing 
The parser assumed that its input was a NUL-terminated string, but it
was not the case: it is just the raw output of "adb devices ip route".

In practice, it was harmless, since the output always ended with '\n'
(which was replaced by '\0' on truncation), but it was incorrect
nonetheless.

Always write a '\0' at the end of the buffer, and explicitly parse as a
NUL-terminated string. For that purpose, avoid the error-prone
sc_str_truncate() util function.
 2022-02-06 14:30:07 +01:00
Romain Vimont
7810ca61b0 Move ADB code to adb/ 2022-02-04 08:39:10 +01:00
Romain Vimont
9d2e00697e Use sc_ prefix for control_msg enums 
Refs afa4a1b728
 2022-01-27 16:47:51 +01:00
Romain Vimont
afa4a1b728 Use sc_ prefix for control_msg 2022-01-14 22:17:30 +01:00
Romain Vimont
924375487e Pass buttons state in scroll events 
A scroll event might be produced when a mouse button is pressed (for
example when scrolling while selecting a text). For consistency, pass
the actual buttons state (instead of 0).

In practice, it seems that this use case does not work properly with
Android event injection, but it will work with HID mouse.
 2022-01-04 17:41:40 +01:00
Romain Vimont
d540c72e7c Rename SC_MOD_* to SC_SHORTCUT_MOD_* 
This will avoid conflicts with new SC_MOD_* constants.
 2022-01-01 23:28:45 +01:00
Romain Vimont
1fbc590b26 Fix memory leaks in tests 
Tests were failing when run with ASAN enabled.
 2021-12-31 10:49:22 +01:00
Romain Vimont
90cf956f57 Remove spurious ';' 2021-12-04 09:29:30 +01:00
Romain Vimont
ae90ef22db Add a unit test for clipboard text length 
This would have catched the possible memcpy() overflow fixed by the
previous commit.

Refs #2859 <https://github.com/Genymobile/scrcpy/pull/2859>
 2021-12-04 09:22:35 +01:00
Romain Vimont
94702a4309 Fix memset() size in tests 
The memset() size was 1 byte too long. It was harmless because the last
'a' was overwritten by '\0`.
 2021-12-04 09:12:20 +01:00
Romain Vimont
e2b3968c66 Always synchronize clipboard on explicit COPY/CUT 
If --no-clipboard-autosync is enabled, the automatic clipboard
synchronization performed whenever the device clipboard changes is
disabled.

But on explicit COPY and CUT scrcpy shortcuts (MOD+c and MOD+x), the
clipboard should still be synchronized, so that it remains possible to
copy-paste from the device to the computer.

This is consistent with the behavior of MOD+v, which pastes the computer
clipboard to the device.

Refs #2228 <https://github.com/Genymobile/scrcpy/issues/2228>
Refs #2817 <https://github.com/Genymobile/scrcpy/pull/2817>
PR #2834 <https://github.com/Genymobile/scrcpy/pull/2834>
 2021-11-29 22:00:55 +01:00
Romain Vimont
5e918ac0c3 Use enum for key injection mode 
There was only two key injection modes:
 - the default one
 - the mode with --prefer-text enabled

To prepare the addition of another mode (--raw-key-events), use an enum
instead of a bool.

PR #2831 <https://github.com/Genymobile/scrcpy/pull/2831>
 2021-11-29 21:15:32 +01:00
Romain Vimont
f609b406c9 Add function to find the device IP address 
Parse the result of "adb shell ip route" to find the device IP address.

PR #2827 <https://github.com/Genymobile/scrcpy/pull/2827>
 2021-11-29 20:39:03 +01:00
Romain Vimont
b7e631791c Add util function to remove trailing '\r' 
Depending on the platform and adb versions, the lines output by adb
could end with "\r\r\n". This util function helps to remove all trailing
'\r'.

PR #2827 <https://github.com/Genymobile/scrcpy/pull/2827>
 2021-11-29 20:39:03 +01:00
Romain Vimont
b52f87a892 Add util function to locate a column in a string 
This will help to parse the result of "adb shell ip route" to find the
device IP address.

PR #2827 <https://github.com/Genymobile/scrcpy/pull/2827>
 2021-11-29 20:39:03 +01:00
Romain Vimont
007f616302 Add missing includes 
Include these headers explicitly instead of relying on transitivity.
 2021-11-24 21:44:29 +01:00
Romain Vimont
2a0730ee9b Add device clipboard set acknowledgement 
Add a device message type so that the device could send acknowledgements
for SET_CLIPBOARD requests.

PR #2814 <https://github.com/Genymobile/scrcpy/pull/2814>
 2021-11-23 21:15:05 +01:00
Romain Vimont
901d837165 Add sequence number to set_clipboard request 
This will allow the client to request an acknowledgement.

PR #2814 <https://github.com/Genymobile/scrcpy/pull/2814>
 2021-11-23 21:15:05 +01:00
Romain Vimont
0427a981e5 Use UINT64_C macro for uint64_t constant in tests 
A long constant might not be sufficient.
 2021-11-21 22:57:33 +01:00
Romain Vimont
9619ade706 Generalize string trunctation util function 
Add an additional argument to let the client pass the possible end
chars.
 2021-11-18 18:48:16 +01:00
Romain Vimont
f2781a8b6d Expose util function to truncate first line 
Move the local implementation from adb functions to the string util
functions.
 2021-11-18 18:48:16 +01:00
Romain Vimont
057c7a4df4 Move str_util to str 
Simplify naming.
 2021-11-14 01:22:22 +01:00
Romain Vimont
979ce64dc0 Improve string util API 
Use prefixed names and improve documentation.
 2021-11-14 01:22:22 +01:00
Romain Vimont
9ec3406568 Add line wrapper 
Add a tool to wrap lines at words boundaries (spaces) to fit in a
specified number of columns, left-indented by a specified number of
spaces.
 2021-11-11 14:55:53 +01:00
Romain Vimont
6dba1922c1 Add string buffer util 
This will help to build strings incrementally.
 2021-11-11 14:55:52 +01:00
Romain Vimont
27fa23846d Define default options as const struct 
This is more readable than a macro, and we could ifdef some fields.
 2021-10-27 18:43:47 +02:00
Romain Vimont
e4d5c1ce36 Move scrcpy option structs to options.h 
This will allow to define symbols in options.c without all the
dependencies of scrcpy.c.
 2021-10-27 18:43:47 +02:00
Romain Vimont
2f03141e9f Add clock tests 
The clock rolling sum is not trivial. Test it.
 2021-07-14 14:54:22 +02:00
Romain Vimont
099cba07f0 Rename queue to sc_queue 
Add a scrcpy-specific prefix.
 2021-07-14 00:35:10 +02:00
Romain Vimont
f76fe2c0d4 Fix --lock-video-orientation syntax 
The argument for option --lock-video-orientation has been made optional
by 5af9d0ee0f.

With getopt_long(), contrary to mandatory arguments, optional arguments
must be given with a '=':

    --lock-video-orientation 2   # wrong, parse error
    --lock-video-orientation=2   # correct
 2021-06-11 18:40:12 +02:00