Android/scrcpy
1
0
Fork 0
Code Issues Pull requests Projects Releases 1 Packages Wiki Activity
1539 commits 2 branches 1 tag 4.1 MiB
Commit graph

1539 commits

This branch
This branch
All branches
Author SHA1 Message Date
Romain Vimont
d31725f077 Reorder cli sanity checks 
Check unexpected additional arguments before other sanity checks.
 2021-11-25 22:22:34 +01:00
Romain Vimont
b0eb1a55d6 Fix adb get-serialno error handling 
If pipe read fails, return.
 2021-11-25 22:22:34 +01:00
Romain Vimont
3653fb6b15 Add OutOfMemory log helper 
Add a special LOG_OOM() function to log all OutOfMemory errors (i.e.
allocations returning NULL).
 2021-11-24 22:06:49 +01:00
Romain Vimont
92a458e846 Remove unreachable return statements 2021-11-24 21:48:57 +01:00
Romain Vimont
73e0311d14 Add missing return on file_handler failure 
Mistake introduced by 84334cf7db.
 2021-11-24 21:46:02 +01:00
Romain Vimont
007f616302 Add missing includes 
Include these headers explicitly instead of relying on transitivity.
 2021-11-24 21:44:29 +01:00
Romain Vimont
4c47598865 Make lockVideoOrientation option name uniform 
On the server, the option was named lockedVideoOrientation.
 2021-11-24 21:33:58 +01:00
Romain Vimont
7b29f5fd2d Do not pass default values to the server 
By default, only pass the version and the bit rate (the default bitrate
is a client compilation option).
 2021-11-24 21:31:12 +01:00
Romain Vimont
04e5537f8c Pass server parameters as key=value pairs 
The options values to configure the server were identified by their
command-line argument index. Now that there are a lot of arguments, many
of them being booleans, it became unreadable and error-prone.

Identify the arguments by a key string instead, and make them optional.

This will also simplify running the server manually for debugging.
 2021-11-24 21:23:20 +01:00
Romain Vimont
2eb881c5f1 Allocate and format server command args 
This simplifies formatting.
 2021-11-24 21:10:18 +01:00
Romain Vimont
2c3099e2de Parse codec options early 
For consistency with other options, parse the codec options on the
server before storing them in the Options instance.
 2021-11-24 21:06:02 +01:00
Romain Vimont
5434ea543c Remove local "serial" variable 
In execute_server(), the serial is used only once. Moreover, it can be
retrieved from the `params` argument directly.
 2021-11-24 21:01:25 +01:00
Romain Vimont
d5f6697f3a Add (v)asprintf compatibility functions 
In case they are not available on the platform.
 2021-11-24 19:55:00 +01:00
Romain Vimont
d6c0054545 Move check_functions in meson script 
Move the variable to the place it is actually used.
 2021-11-24 19:38:33 +01:00
Romain Vimont
6f487a2892 Add missing includes in compat implementation 
These includes are necessary for the strdup() compat implementation.
 2021-11-24 19:37:33 +01:00
Romain Vimont
dc0ac01e00 Define common feature test macros for all systems 
_POSIX_C_SOURCE, _XOPEN_SOURCE and _GNU_SOURCE are also used on Windows.

Fix regression introduced by ba547e3895.
 2021-11-24 19:36:33 +01:00
Romain Vimont
6abff46c9f Add option to disable clipboard autosync 
By default, scrcpy automatically synchronizes the computer clipboard to
the device clipboard before injecting Ctrl+v, and the device clipboard
to the computer clipboard whenever it changes.

This new option --no-clipboard-autosync disables this automatic
synchronization.

Fixes #2228 <https://github.com/Genymobile/scrcpy/issues/2228>
PR #2817 <https://github.com/Genymobile/scrcpy/pull/2817>
 2021-11-24 09:44:39 +01:00
Romain Vimont
5d17bcf1bc Wait SET_CLIPBOARD ack before Ctrl+v via HID 
To allow seamless copy-paste, on Ctrl+v, a SET_CLIPBOARD request is
performed before injecting Ctrl+v.

But when HID keyboard is enabled, the Ctrl+v injection is not sent on
the same channel as the clipboard request, so they are not serialized,
and may occur in any order. If Ctrl+v happens to be injected before the
new clipboard content is set, then the old content is pasted instead,
which is incorrect.

To minimize the probability of occurrence of the wrong order, a delay of
2 milliseconds was added before injecting Ctrl+v. Then 5ms. But even
with 5ms, the wrong behavior sometimes happens.

To handle it properly, add an acknowledgement mechanism, so that Ctrl+v
is injected over AOA only after the SET_CLIPBOARD request has been
performed and acknowledged by the server.

Refs e4163321f0
Refs 45b0f8123a

PR #2814 <https://github.com/Genymobile/scrcpy/pull/2814>
 2021-11-24 09:41:21 +01:00
Romain Vimont
2d5525eac1 Move PRIu64 Windows workaround to compat.h 
So that we can use it from several files.

PR #2814 <https://github.com/Genymobile/scrcpy/pull/2814>
 2021-11-23 21:15:05 +01:00
Romain Vimont
41abe021e2 Make the device acknowledge device clipboard 
If the client provided a sequence number on SET_CLIPBOARD request, make
the device send back an acknowledgement once the clipboard is set.

PR #2814 <https://github.com/Genymobile/scrcpy/pull/2814>
 2021-11-23 21:15:05 +01:00
Romain Vimont
2a0730ee9b Add device clipboard set acknowledgement 
Add a device message type so that the device could send acknowledgements
for SET_CLIPBOARD requests.

PR #2814 <https://github.com/Genymobile/scrcpy/pull/2814>
 2021-11-23 21:15:05 +01:00
Romain Vimont
901d837165 Add sequence number to set_clipboard request 
This will allow the client to request an acknowledgement.

PR #2814 <https://github.com/Genymobile/scrcpy/pull/2814>
 2021-11-23 21:15:05 +01:00
Romain Vimont
aba1fc03c3 Add acksync helper to wait for acks 
This will allow to send requests with sequence numbers to the server
and wait for acknowledgements.

PR #2814 <https://github.com/Genymobile/scrcpy/pull/2814>
 2021-11-23 21:15:05 +01:00
Romain Vimont
5b3856c3b6 Explicitly indicate when device clipboard is set 
Pass the information that device clipboard has been set to the key
processor. This avoids the keyprocessor to "guess", and paves the way to
implement a proper acknowledgement mechanism.

PR #2814 <https://github.com/Genymobile/scrcpy/pull/2814>
 2021-11-23 21:15:05 +01:00
Romain Vimont
854de9659a Do not inject Ctrl+v if clipboard sync failed 
This prevents to paste the current Android clipboard, which would be
unexpected.

PR #2814 <https://github.com/Genymobile/scrcpy/pull/2814>
 2021-11-23 21:15:05 +01:00
Romain Vimont
ea8028332c Synchronize computer-to-device empty clipboard 
Set the device clipboard to empty string if necessary. Otherwise, the
current device clipboard will be pasted on Ctrl+v.

PR #2814 <https://github.com/Genymobile/scrcpy/pull/2814>
 2021-11-23 21:14:49 +01:00
Romain Vimont
0427a981e5 Use UINT64_C macro for uint64_t constant in tests 
A long constant might not be sufficient.
 2021-11-21 22:57:33 +01:00
Romain Vimont
44721ed982 Document remote ADB server in README 
Refs #2807 <https://github.com/Genymobile/scrcpy/pull/2807>
 2021-11-21 22:37:52 +01:00
Romain Vimont
68eaee5bb0 Force adb forward if tunnel host/port is provided 
Tunnel host and port are only meaningful in "adb forward" mode.

They indicate where the client must connect to communicate with the
server. In "adb reverse" mode, the client _listens_, it does not
_connect_.

Refs #2807 <https://github.com/Genymobile/scrcpy/pull/2807>
 2021-11-21 22:37:52 +01:00
RipleyTom
7bdbde7363 Add options to configure tunnel host and port 
In "adb forward" mode, by default, scrcpy connects to localhost:PORT,
where PORT is the local port passed to "adb forward". This assumes that
the tunnel is established on the local host with a local adb server
(which is the common case).

For advanced usage, add --tunnel-host and --tunnel-port to force the
connection to a different destination.

Fixes #2801 <https://github.com/Genymobile/scrcpy/issues/2801>
PR #2807 <https://github.com/Genymobile/scrcpy/pull/2807>

Signed-off-by: Romain Vimont <rom@rom1v.com>
 2021-11-21 22:37:52 +01:00
RipleyTom
52e5181c84 Add function to parse IPv4 addresses 
PR #2807 <https://github.com/Genymobile/scrcpy/pull/2807>

Signed-off-by: Romain Vimont <rom@rom1v.com>
 2021-11-21 22:37:37 +01:00
Romain Vimont
ba547e3895 Configure feature test macros in meson 
Refs #2807 <https://github.com/Genymobile/scrcpy/pull/2807>

Co-authored-by: RipleyTom <RipleyTom@users.noreply.github.com>
 2021-11-21 00:20:11 +01:00
Romain Vimont
226f3b2c91 Add missing include config.h 2021-11-21 00:13:25 +01:00
Romain Vimont
2d6a96776c Improve SSH tunnel documentation in README 2021-11-19 21:03:29 +01:00
Romain Vimont
6da6d905c2 Print scrcpy header first 
Inconditionnally print the scrcpy version first, without using LOGI().

The log level is configured only after parsing the command line
parameters (it may be changed via -V), and command line parsing logs
should not appear before the scrcpy version.
 2021-11-19 09:45:02 +01:00
Romain Vimont
b25404ee4b Print help to stdout 
The output of -h/--help was printed on stderr, although it is not an
error.

Printing on stdout allows to pipe the result directly:

    scrcpy --help | less

Instead of (in bash):

    scrcpy --help |& less
 2021-11-19 08:18:13 +01:00
Romain Vimont
4cfc1cd70a Assert that long options are correctly set 2021-11-19 08:06:23 +01:00
Romain Vimont
2fc80eae2d Simplify adb_tunnel 
With the new adb functions, the static adb_tunnel functions become
unnecessary.
 2021-11-19 07:25:03 +01:00
Romain Vimont
3fdbd994e0 Privatize low-level adb functions 
Only expose the interruptible user-friendly API.
 2021-11-19 07:25:03 +01:00
Romain Vimont
ce225f019a Use new user-friendly adb API 
Replace the adb_exec_*() calls by the new adb functions to simplify.
 2021-11-18 22:11:19 +01:00
Romain Vimont
b7559744a7 Expose new user-friendly adb functions 
Expose interruptible adb functions which return the expected result
directly, without exposing the process (sc_pid) to the caller.
 2021-11-18 22:08:15 +01:00
Romain Vimont
afb5a5e80f Rename adb functions to adb_exec_* 
This paves the way to replace them by more user-friendly functions that
will call them internally.
 2021-11-18 21:47:17 +01:00
Romain Vimont
84334cf7db Use sc_intr in file_handler 
Replace manual interruption handling by the recent sc_intr mechanism.
 2021-11-18 21:33:25 +01:00
Romain Vimont
0ba2686e1d Simplify file_handler 
Call the target functions directly.
 2021-11-18 19:46:47 +01:00
Romain Vimont
55648d4d64 Improve file_handler readability 
Use local variables as short name aliases.
 2021-11-18 19:46:40 +01:00
Romain Vimont
13fd693b50 Simplify adb_execute_p() 
Only pass the stdout pipe as parameter, scrcpy never writes to stdin or
reads from stderr of an adb process.
 2021-11-18 19:43:10 +01:00
Romain Vimont
0426ae885c Make "adb get-serialno" interruptible 
All process executions must be interruptible, so that Ctrl+c reacts
immediately.
 2021-11-18 19:41:41 +01:00
Romain Vimont
ea454e9cee Add interruptible function to read from pipe 
This will avoid to block Ctrl+c if the process the pipe is read from
takes too much time.
 2021-11-18 19:39:11 +01:00
Romain Vimont
cb65531533 Simplify sc_str_truncate() 
Use strcspn() to get the prefix length directly.
 2021-11-18 19:37:53 +01:00
Romain Vimont
9619ade706 Generalize string trunctation util function 
Add an additional argument to let the client pass the possible end
chars.
 2021-11-18 18:48:16 +01:00