Jerry/bird
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Nest: Fix race condition during reconfiguration, part 2

Browse source 
If export filter is changed during reconfiguration and a route disappears
between reconfiguration and refeed (e.g., if the route is a static route
also removed during the reconfiguration), the route is not withdrawn.

The issue was fixed for regular channels by an earlier patch. This patch
fixes the issue for channels in RA_ACCEPTED mode (first-pass-the-filter),
used by BGP with 'secondary' option.
This commit is contained in:
Ondrej Zajicek (work) 2018-07-06 02:04:45 +02:00
parent 7b9b0c0a00
commit 092c493027
1 changed files with 10 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
nest/rt-table.c
View file

@ -678,8 +678,18 @@ rt_notify_accepted(struct channel *c, net *net, rte *new_changed, rte *old_chang
* *
* - We found new_best the same as new_changed, therefore it cannot * - We found new_best the same as new_changed, therefore it cannot
* be old_best and we have to continue search for old_best. * be old_best and we have to continue search for old_best.
*
* There is also a hack to ensure consistency in case of changed filters.
* It does not find the proper old_best, just selects a non-NULL route.
*/ */
/* Hack for changed filters */
if (old_changed && (old_changed->lastmod <= c->last_tx_filter_change))
{
old_best = old_changed;
goto found;
}
/* First case */ /* First case */
if (old_meet) if (old_meet)
if (old_best = export_filter(c, old_changed, &old_free, 1)) if (old_best = export_filter(c, old_changed, &old_free, 1))