Jerry/bird
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

OSPF: Fix some trace messages

Browse source 
Missing argument in MTU change trace message can crash bird when MTU
change happens and trace messages are active.

Thanks to Alexander Velkov for the bugreport.
This commit is contained in:
Ondrej Zajicek (work) 2018-10-25 17:22:37 +02:00
parent df50598f1c
commit 0ac9cb2c1f
2 changed files with 3 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
proto/ospf/hello.c
View file

@ -290,7 +290,7 @@ ospf_receive_hello(struct ospf_packet *pkt, struct ospf_iface *ifa,
if (!ipa_equal(faddr, n->ip)) if (!ipa_equal(faddr, n->ip))
{ {
OSPF_TRACE(D_EVENTS, "Neighbor %R on %s changed IP address to %I", OSPF_TRACE(D_EVENTS, "Neighbor %R on %s changed IP address to %I",
n->rid, ifa->ifname, n->ip, faddr); n->rid, ifa->ifname, faddr);
n->ip = faddr; n->ip = faddr;
} }
} }

3
proto/ospf/iface.c
View file

@ -1278,7 +1278,8 @@ ospf_iface_change_mtu(struct ospf_proto *p, struct ospf_iface *ifa)
{ {
/* ifa is not vlink */ /* ifa is not vlink */
OSPF_TRACE(D_EVENTS, "Interface %s changed MTU to %d", ifa->iface->mtu); OSPF_TRACE(D_EVENTS, "Interface %s changed MTU to %d",
ifa->ifname, ifa->iface->mtu);
ifa->tx_length = ifa_tx_length(ifa); ifa->tx_length = ifa_tx_length(ifa);