Jerry/bird
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

OSPF: Adding a note about a static analyzer result.

Browse source
This commit is contained in:
Maria Matejka 2019-08-16 14:04:53 +02:00
parent dccee40826
commit 9e64ac4b7c
1 changed files with 8 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
proto/ospf/topology.c
View file

@ -329,6 +329,14 @@ ospf_originate_lsa(struct ospf_proto *p, struct ospf_new_lsa *lsa)
en->next_lsa_opts = 0; en->next_lsa_opts = 0;
} }
/* The static analyzer complains here that en->lsa_body may be NULL.
* Yes, it may if ospf_hash_get() creates a new struct top_hash_entry.
* In this case, also en->lsa.length must be 0 and lsa_length is never
* equal to 0 while sizeof(struct ospf_lsa_header) is non-zero.
* Therefore memcmp() is never executed with NULL here.
* */
ASSUME((en->lsa.length == 0) == (en->lsa_body == NULL));
/* Ignore the the new LSA if is the same as the current one */ /* Ignore the the new LSA if is the same as the current one */
if ((en->lsa.age < LSA_MAXAGE) && if ((en->lsa.age < LSA_MAXAGE) &&
(lsa_length == en->lsa.length) && (lsa_length == en->lsa.length) &&