FIXME's updated. One fixme is remaining for correct RIPv4. Wow.

This commit is contained in:
Pavel Machek 1999-11-04 14:39:51 +00:00
parent 7bf19253d0
commit a5b583f20a

View file

@ -8,8 +8,7 @@
FIXME: IpV6 support: packet size FIXME: IpV6 support: packet size
FIXME: IpV6 support: use right address for broadcasts FIXME: IpV6 support: use right address for broadcasts
FIXME: IpV6 support: receive "route using" blocks FIXME: IpV6 support: receive "route using" blocks
FIXME: be able to transmit "route using" blocks [Is this possible?] 1 FIXME
6 FIXMEs in code
*/ */
#define LOCAL_DEBUG #define LOCAL_DEBUG
@ -97,7 +96,7 @@ rip_tx( sock *s )
packet->block[i].nexthop = IPA_NONE; packet->block[i].nexthop = IPA_NONE;
{ {
neighbor *n1, *n2; neighbor *n1, *n2;
n1 = neigh_find( p, &s->daddr, 0 ); n1 = neigh_find( p, &s->daddr, 0 ); /* FIXME, mj: this is neccessary for responses, still it is too complicated for common case */
n2 = neigh_find( p, &e->nexthop, 0 ); n2 = neigh_find( p, &e->nexthop, 0 );
if (n1->iface == n2->iface) if (n1->iface == n2->iface)
packet->block[i].nexthop = e->nexthop; packet->block[i].nexthop = e->nexthop;
@ -221,7 +220,7 @@ advertise_entry( struct proto *p, struct rip_block *b, ip_addr whotoldme )
#endif #endif
A.from = whotoldme; A.from = whotoldme;
/* FIXME: Check if destination looks valid - ie not net 0 or 127 */ /* No need to look if destination looks valid - ie not net 0 or 127 -- core will do for us. */
neighbor = neigh_find( p, &A.gw, 0 ); neighbor = neigh_find( p, &A.gw, 0 );
if (!neighbor) { if (!neighbor) {