Jerry/bird
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

OSPFv3: Update neighbor authentication state from Hello packets

Browse source 
In OSPFv3, only Hello and DBDes packets contain flags specifying whether
RFC 7166 authentication trailer is used. Other packets are processed
based on stored authentication state in neighbor structure. Update this
state with each received Hello to handle authentication change from
reconfigurations.

Thanks to Joakim Tjernlund and Kenth Eriksson for the bugreport.
This commit is contained in:
Ondrej Zajicek (work) 2021-03-16 16:34:42 +01:00
parent 94abefc00b
commit ae9ae864d3
1 changed files with 11 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
proto/ospf/hello.c
View file

@ -294,6 +294,14 @@ ospf_receive_hello(struct ospf_packet *pkt, struct ospf_iface *ifa,
n->ip = faddr; n->ip = faddr;
} }
} }
/* Update RFC 7166 authentication trailer flag */
if (ospf_is_v3(p) && ((rcv_options ^ n->options) & OPT_AT))
{
OSPF_TRACE(D_EVENTS, "Neighbor %R on %s %s authentication",
n->rid, ifa->ifname, (rcv_options & OPT_AT) ? "enabled" : "disabled");
n->options = (n->options & ~OPT_AT) | (rcv_options & OPT_AT);
}
} }
if (!n) if (!n)
@ -326,6 +334,9 @@ ospf_receive_hello(struct ospf_packet *pkt, struct ospf_iface *ifa,
n->priority = rcv_priority; n->priority = rcv_priority;
n->iface_id = rcv_iface_id; n->iface_id = rcv_iface_id;
if (ospf_is_v3(p))
n->options = rcv_options & OPT_AT;
if (n->ifa->cf->bfd) if (n->ifa->cf->bfd)
ospf_neigh_update_bfd(n, n->ifa->bfd); ospf_neigh_update_bfd(n, n->ifa->bfd);
} }