Jerry/bird
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Nest: Do not ignore secondary flag changes in ifa updates

Browse source 
Compare all IA_* flags that are set by sysdep iface code.

The old code ignores IA_SECONDARY flag when comparing whether iface
address updates from kernel changed anything. This is usually not an
issue as kernel removes all secondary addresses due to removal of the
primary one, but it breaks when sysctl 'promote_secondaries' is enabled
and kernel promotes secondary addresses to primary ones.

Thanks to 'Alexander' for the bugreport.
This commit is contained in:
Ondrej Zajicek (work) 2021-12-18 00:58:47 +01:00
parent f772afc525
commit b21104c97e
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
nest/iface.c
View file

@ -591,7 +591,7 @@ ifa_update(struct ifa *a)
if (ipa_equal(b->brd, a->brd) && if (ipa_equal(b->brd, a->brd) &&
ipa_equal(b->opposite, a->opposite) && ipa_equal(b->opposite, a->opposite) &&
b->scope == a->scope && b->scope == a->scope &&
!((b->flags ^ a->flags) & IA_PEER)) !((b->flags ^ a->flags) & (IA_SECONDARY | IA_PEER | IA_HOST)))
{ {
b->flags |= IA_UPDATED; b->flags |= IA_UPDATED;
return b; return b;