Jerry/bird
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Fixes bug in BGPv6 causing crash by checking missing attributes.

Browse source
This commit is contained in:
Ondrej Zajicek 2009-04-23 12:36:24 +02:00
parent e366625c0e
commit b9539e78d8
1 changed files with 10 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
proto/bgp/attrs.c
View file

@ -1359,17 +1359,19 @@ bgp_decode_attrs(struct bgp_conn *conn, byte *attr, unsigned int len, struct lin
mandatory = 1; mandatory = 1;
#endif #endif
/* If there is no (reachability) NLRI, we should exit now */
if (! mandatory)
return a;
/* Check if all mandatory attributes are present */ /* Check if all mandatory attributes are present */
if (mandatory) for(i=0; i < ARRAY_SIZE(bgp_mandatory_attrs); i++)
{ {
for(i=0; i < ARRAY_SIZE(bgp_mandatory_attrs); i++) code = bgp_mandatory_attrs[i];
if (!(seen[code/8] & (1 << (code%8))))
{ {
code = bgp_mandatory_attrs[i]; bgp_error(conn, 3, 3, &bgp_mandatory_attrs[i], 1);
if (!(seen[code/8] & (1 << (code%8)))) return NULL;
{
bgp_error(conn, 3, 3, &bgp_mandatory_attrs[i], 1);
return NULL;
}
} }
} }