Jerry/bird
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Nest: Fix recursive route update

Browse source 
Missing cleanup can lead to dangling pointer to old next hops.
This commit is contained in:
Ondrej Zajicek (work) 2019-10-10 14:01:16 +02:00
parent 09ee846d92
commit cb2b6e0494
1 changed files with 2 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
nest/rt-table.c
View file

@ -2109,9 +2109,10 @@ no_nexthop:
else else
{ {
nhr = nhp; nhr = nhp;
nhp = (nhp ? (nhp->next = lp_allocz(rte_update_pool, NEXTHOP_MAX_SIZE)) : &(a->nh)); nhp = (nhp ? (nhp->next = lp_alloc(rte_update_pool, NEXTHOP_MAX_SIZE)) : &(a->nh));
} }
memset(nhp, 0, NEXTHOP_MAX_SIZE);
nhp->iface = nh->iface; nhp->iface = nh->iface;
nhp->weight = nh->weight; nhp->weight = nh->weight;
if (mls) if (mls)