Jerry/bird
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

No more warnings ...

Browse source 
no more warnings
No more warnings over me
And while it is being compiled all the log is black and white
Release BIRD now and then let it flee

(use the melody of well-known Oh Freedom!)
This commit is contained in:
Jan Maria Matejka 2018-09-18 14:21:11 +02:00
parent d50b0bc437
commit d4cebc6bbe
10 changed files with 27 additions and 15 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
lib/printf.c
View file

@ -424,6 +424,7 @@ int bvsnprintf(char *buf, int size, const char *fmt, va_list args)
case 'X':
flags |= LARGE;
/* fallthrough */
case 'x':
base = 16;
break;

2
nest/a-path.c
View file

@ -805,7 +805,7 @@ as_path_match(const struct adata *path, struct f_path_mask *mask)
val2 = val = mask->val;
goto step;
case PM_ASN_EXPR:
ASSERT(0);
bug("Expressions should be evaluated on AS path mask construction.");
case PM_ASN_RANGE:
val = mask->val;
val2 = mask->val2;

2
proto/bfd/packets.c
View file

@ -141,6 +141,7 @@ bfd_fill_authentication(struct bfd_proto *p, struct bfd_session *s, struct bfd_c
case BFD_AUTH_METICULOUS_KEYED_MD5:
case BFD_AUTH_METICULOUS_KEYED_SHA1:
meticulous = 1;
/* fallthrough */
case BFD_AUTH_KEYED_MD5:
case BFD_AUTH_KEYED_SHA1:
@ -230,6 +231,7 @@ bfd_check_authentication(struct bfd_proto *p, struct bfd_session *s, struct bfd_
case BFD_AUTH_METICULOUS_KEYED_MD5:
case BFD_AUTH_METICULOUS_KEYED_SHA1:
meticulous = 1;
/* fallthrough */
case BFD_AUTH_KEYED_MD5:
case BFD_AUTH_KEYED_SHA1:

1
proto/ospf/dbdes.c
View file

@ -353,6 +353,7 @@ ospf_receive_dbdes(struct ospf_packet *pkt, struct ospf_iface *ifa,
ospf_neigh_sm(n, INM_2WAYREC);
if (n->state != NEIGHBOR_EXSTART)
return;
/* fallthrough */
case NEIGHBOR_EXSTART:
if ((ifa->type != OSPF_IT_VLINK) &&

1
proto/ospf/ospf.c
View file

@ -1200,6 +1200,7 @@ ospf_sh_state(struct proto *P, int verbose, int reachable)
he->domain = 1; /* Abuse domain field to mark the LSA */
hex[jx++] = he;
}
/* fallthrough */
default:
accept = 0;
}

1
proto/ospf/packet.c
View file

@ -57,6 +57,7 @@ ospf_pkt_finalize2(struct ospf_iface *ifa, struct ospf_packet *pkt, uint *plen)
return;
}
strncpy(auth->password, pass->password, sizeof(auth->password));
/* fallthrough */
case OSPF_AUTH_NONE:
{

1
proto/radv/radv.c
View file

@ -230,6 +230,7 @@ radv_iface_notify(struct radv_iface *ifa, int event)
{
case RA_EV_CHANGE:
radv_invalidate(ifa);
/* fallthrough */
case RA_EV_INIT:
ifa->initial = MAX_INITIAL_RTR_ADVERTISEMENTS;
radv_prepare_prefixes(ifa);

18
proto/rip/packets.c
View file

@ -58,13 +58,17 @@ struct rip_block_auth
{
u16 must_be_ffff;
u16 auth_type;
char password[0];
u16 packet_len;
u8 key_id;
u8 auth_len;
u32 seq_num;
u32 unused1;
u32 unused2;
union {
char password[16];
struct {
u16 packet_len;
u8 key_id;
u8 auth_len;
u32 seq_num;
u32 unused1;
u32 unused2;
};
};
};
/* Authentication tail, RFC 4822 */

12
sysdep/unix/io.c
View file

@ -1128,7 +1128,7 @@ sk_ssh_connect(sock *s)
default:
return SSH_ERROR;
}
}
} /* fallthrough */
case SK_SSH_SERVER_KNOWN:
{
@ -1175,7 +1175,7 @@ sk_ssh_connect(sock *s)
if (!server_identity_is_ok)
return SSH_ERROR;
}
}
} /* fallthrough */
case SK_SSH_USERAUTH:
{
@ -1191,7 +1191,7 @@ sk_ssh_connect(sock *s)
default:
return SSH_ERROR;
}
}
} /* fallthrough */
case SK_SSH_CHANNEL:
{
@ -1199,7 +1199,7 @@ sk_ssh_connect(sock *s)
s->ssh->channel = ssh_channel_new(s->ssh->session);
if (s->ssh->channel == NULL)
return SSH_ERROR;
}
} /* fallthrough */
case SK_SSH_SESSION:
{
@ -1215,7 +1215,7 @@ sk_ssh_connect(sock *s)
default:
return SSH_ERROR;
}
}
} /* fallthrough */
case SK_SSH_SUBSYSTEM:
{
@ -1234,7 +1234,7 @@ sk_ssh_connect(sock *s)
return SSH_ERROR;
}
}
}
} /* fallthrough */
case SK_SSH_ESTABLISHED:
s->ssh->state = SK_SSH_ESTABLISHED;

3
sysdep/unix/krt.c
View file

@ -784,7 +784,8 @@ krt_got_route_async(struct krt_proto *p, rte *e, int new)
switch (e->u.krt.src)
{
case KRT_SRC_BIRD:
ASSERT(0); /* Should be filtered by the back end */
/* Should be filtered by the back end */
bug("BIRD originated routes should not get here.");
case KRT_SRC_REDIRECT:
if (new)