Jerry/bird
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Nest: Prevent withdraws from propagation back to source protocol

Browse source 
The earlier fix loosen conditions for not running filters on old
route when deciding about route propagation to a protocol to avoid
issues with ghost routes in some race conditions.

Unfortunately, the fix also caused back-propagation of withdraws. For
regular updates, back-propagation is prevented in import_control hooks,
but these are not called on withdraws. For them, import_control hooks
are called on old routes instead, changing (old, NULL) notification
to (NULL, NULL), which is ignored. By not calling export processing
in some cases, the withdraw is not ignored and is back-propagated.

This patch fixes that by contract conditions so the earlier fix is not
applied to back-propagated updates.
This commit is contained in:
Ondrej Zajicek (work) 2019-01-30 17:25:21 +01:00
parent ee95f281f0
commit e84c81b76f
1 changed files with 2 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
nest/rt-table.c
View file

@ -571,7 +571,8 @@ rt_notify_basic(struct channel *c, net *net, rte *new0, rte *old0, int refeed)
if (new) if (new)
new = export_filter(c, new, &new_free, 0); new = export_filter(c, new, &new_free, 0);
if (old && !(refeed || (old->lastmod <= c->last_tx_filter_change))) if (old && !(refeed || ((old->lastmod <= c->last_tx_filter_change) &&
(p != old->sender->proto))))
old = export_filter(c, old, &old_free, 1); old = export_filter(c, old, &old_free, 1);
if (!new && !old) if (!new && !old)