Jerry/bird
1
0
Fork 0
Code Issues Pull requests Packages Projects Releases Wiki Activity

Fixed a bunch of FIXME's by removing them :)

Browse source
This commit is contained in:
Martin Mares 2000-03-12 22:53:05 +00:00
parent 4327090276
commit f098e072be
6 changed files with 10 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
TODO
View file

@ -1,5 +1,7 @@
Core Core
~~~~ ~~~~
- config: when parsing prefix, check zero bits
- static: check validity of route destination? - static: check validity of route destination?
- static: allow specifying a per-route filter program for setting route attributes? - static: allow specifying a per-route filter program for setting route attributes?
@ -9,7 +11,6 @@ Core
Commands Commands
~~~~~~~~ ~~~~~~~~
- show status
- showing of routing table as seen by given protocol - showing of routing table as seen by given protocol
- printing of dynamic attributes - printing of dynamic attributes
@ -39,7 +40,6 @@ Various ideas
- netlink: import Linux route attributes to our rta's, so that they can be filtered? - netlink: import Linux route attributes to our rta's, so that they can be filtered?
- config: executable config files - config: executable config files
- client: access control - client: access control
- config: when parsing prefix, check zero bits
- io: use poll if available - io: use poll if available
- IPv6 router advertisements - IPv6 router advertisements
- real multipath (doesn't seem to be simple at all :() - real multipath (doesn't seem to be simple at all :()

2
nest/proto.c
View file

@ -283,7 +283,7 @@ proto_rethink_goal(struct proto *p)
mb_free(p); mb_free(p);
if (!nc) if (!nc)
return; return;
p = proto_init(nc); /* FIXME: What about protocol priorities??? */ p = proto_init(nc);
} }
/* Determine what state we want to reach */ /* Determine what state we want to reach */

6
nest/rt-table.c
View file

@ -710,7 +710,11 @@ static void
rt_show_cont(struct cli *c) rt_show_cont(struct cli *c)
{ {
struct rt_show_data *d = c->rover; struct rt_show_data *d = c->rover;
unsigned max = 1; /* FIXME: After some debugging, increase to reasonable amount */ #ifdef DEBUGGING
unsigned max = 4;
#else
unsigned max = 64;
#endif
struct fib *fib = &d->table->fib; struct fib *fib = &d->table->fib;
struct fib_iterator *it = &d->fit; struct fib_iterator *it = &d->fit;

2
sysdep/unix/io.c
View file

@ -897,8 +897,6 @@ io_loop(void)
sock *s; sock *s;
node *n, *p; node *n, *p;
/* FIXME: Use poll() if available */
FD_ZERO(&rd); FD_ZERO(&rd);
FD_ZERO(&wr); FD_ZERO(&wr);
for(;;) for(;;)

2
sysdep/unix/log.c
View file

@ -184,4 +184,6 @@ log_init_debug(char *f)
dbgf = stderr; dbgf = stderr;
else if (!(dbgf = fopen(f, "a"))) else if (!(dbgf = fopen(f, "a")))
log(L_ERR "Error opening debug file `%s': %m", f); log(L_ERR "Error opening debug file `%s': %m", f);
if (dbgf)
setvbuf(dbgf, NULL, _IONBF, 0);
} }

2
sysdep/unix/main.c
View file

@ -385,8 +385,6 @@ main(int argc, char **argv)
dmalloc_debug(0x2f03d00); dmalloc_debug(0x2f03d00);
#endif #endif
setvbuf(stdout, NULL, _IONBF, 0); /* FIXME: Kill some day. */
setvbuf(stderr, NULL, _IONBF, 0);
parse_args(argc, argv); parse_args(argc, argv);
if (debug_flag == 1) if (debug_flag == 1)
log_init_debug(""); log_init_debug("");