Jerry/bird
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity
2293 commits 6 branches 1 tag 7.1 MiB
Commit graph

274 commits

Author SHA1 Message Date
Ondrej Zajicek
d3f36e5978 Fixes BIRD socket unlink. 2009-11-13 14:43:29 +01:00
Ondrej Zajicek
4ac7c8341c Use IPv6 checksums in OSPFv3. 2009-11-09 23:22:53 +01:00
Ondrej Zajicek
3f22fa9e74 Merge branch 'dev' into ospf3 2009-11-09 22:54:39 +01:00
Ondrej Zajicek
ea89da381f Workaround for stupid callback scheduler. 
There is no reak callback scheduler and previous behavior causes
bad things during hard congestion (like BGP hold timeouts).

Smart callback scheduler is still missing, but main loop was
changed such that it first processes all tx callbacks (which
are fast enough) (but max 4* per socket) + rx callbacks for CLI,
and in the second phase it processes one rx callback per
socket up to four sockets (as rx callback can be slow when
there are too many protocols, because route redistribution
is done synchronously inside rx callback). If there is event
callback ready, second phase is skipped in 90% of iterations
(to speed up CLI during congestion).
 2009-10-11 18:56:16 +02:00
Ondrej Zajicek
daeeb8e982 Clear memory allocated by ralloc(). 
This also fixes bug that timer->recurrent was not cleared
in tm_new() and unexpected recurrence of startup timer
in BGP confused state machine and caused crash.
 2009-09-04 11:24:08 +02:00
Ondrej Zajicek
f9c799a00e Temporary OSPFv3 development commit (changing multicast support). 2009-09-04 11:06:51 +02:00
Ondrej Zajicek
061ab802a6 Temporary OSPFv3 development commit 2009-08-27 18:25:46 +02:00
Ondrej Zajicek
6baef17ecf Fixes bug in CLI TX buffer management. 2009-07-14 14:18:54 +02:00
Ondrej Zajicek
2d785e8d6a Fixes bug on TCP passive socket binding on BSD. 
BGP on BSD was bound to random port. I am surprised that
nobody noticed it already.
 2009-06-26 13:33:41 +02:00
Ondrej Zajicek
1876e18d32 Minor bugfix. 2009-06-25 15:44:43 +02:00
Ondrej Zajicek
4323099da9 Fixes bug in scheduling of callback by main loop. 
If other side of a socket is sending data faster than
BIRD is processing, BIRD does not schedule any other
callbacks (events, timers, rx/tx callbacks).
 2009-06-20 00:59:32 +02:00
Ondrej Zajicek
bf1aec970e Adds support for soft reconfiguration. 2009-06-19 23:49:34 +02:00
Ondrej Zajicek
789772ed45 Implements option that changes BGP listening socket parametres. 2009-06-18 19:20:07 +02:00
Ondrej Zajicek
f98e291579 The pipe cleanup. 2009-06-01 14:07:13 +02:00
Ondrej Zajicek
23ac9e9a9e Changes pipes to transfer all routes between routing table, not just optimal routes. 2009-05-31 15:24:27 +02:00
Ondrej Zajicek
874b868544 Implements primary address selection base on 'primary' option. 2009-05-29 22:49:30 +02:00
Ondrej Zajicek
6f68f066b6 Add 'primary' configuration option. 2009-05-29 13:32:24 +02:00
Ondrej Filip
ef9c9ab9b6 OpenBSD port related changes. 2009-05-11 01:32:49 +02:00
Ondrej Filip
2b70f0742e Linux specific TCP-MD5 handling moved to sysdep/linux/sysio.h 
FreeBSD coded added. BSD cannot set BGP passwords itself.
This has to be done by external command.
 2009-05-04 18:17:46 +02:00
Ondrej Filip
1bc4b2cc84 Syntax error fix for systems without CONFIG_SELF_CONSCIOUS (KRT_ALLOW_LEARN) 2009-05-04 17:49:56 +02:00
Ondrej Zajicek
3d574679b8 Fix bugs related to kernel table synchronization. 
KRF_INSTALLED flag was not cleared during reconfiguration
that lead to not removing routes during reconfigure when
export rules changed.

We also should not try to remove routes we didi not installed,
on Linux this leads to warnings (as kernel checks route source
field and do not allow to remove non-bird routes) but we should
not rely on it.
 2009-03-20 12:58:21 +01:00
Ondrej Zajicek
cb53039271 Rate limit for most abundant log messages 2009-02-26 14:23:54 +01:00
Ondrej Zajicek
35164c5017 rx_hook may be cleaned in some callback so we check it before 
executing sk_read().
 2008-12-12 17:48:03 +01:00
Ondrej Zajicek
35f983f889 Fixes segfault with multiple routing tables. 2008-11-21 18:17:03 +01:00
Ondrej Zajicek
eac21b46f7 This is bug, isn't it? 2008-11-21 13:01:05 +01:00
Ondrej Zajicek
fd91ae3325 Fix problem with local time changes. 2008-11-05 22:36:49 +01:00
Ondrej Zajicek
1389f3699f Fixes bugs in IPv6 code caused by recent commits. 2008-11-05 21:39:04 +01:00
Ondrej Zajicek
a39b165e45 Multihop BGP was completely broken, because listening socket has always 
ttl 1.
 2008-11-01 16:58:40 +01:00
Ondrej Zajicek
a98fbf0f12 Merge branch 'dev' into out 2008-10-27 00:20:22 +01:00
Ondrej Zajicek
68fa95cfec Check of socket name length 2008-10-26 23:55:38 +01:00
Ondrej Zajicek
1567edea8d Bugfix for routing table breaking bug. 
Here is a patch fixing a bug that causes breakage of a local routing
table during shutdown of Bird. The problem was caused by shutdown
of 'device' protocol before shutdown of 'kernel' protocol.  When
'device' protocol went down, the route (with local network prefix)
From different protocol (BGP or OSPF) became preferred and installed
to the kernel routing table. Such routes were broken (like
192.168.1.0/24 via 192.168.1.2). I think it is also the cause
of problem reported by Martin Kraus.

The patch disables updating of kernel routing table during shutdown of
Bird. I am not sure whether this is the best way to fix it, I would
prefer to forbid 'kernel' protocol to overwrite routes with
'proto kernel'.

The patch also fixes a problem that during shutdown sometimes routes
created by Bird remained in the kernel routing table.
 2008-10-26 23:09:46 +01:00
Ondrej Zajicek
d51aa28190 Implementation of MD5 authentication of BGP sessions. 2008-10-26 22:42:39 +01:00
Ondrej Filip
97c6fa02e0 Previous patch reverted. :-( 2008-08-25 12:06:20 +00:00
Ondrej Filip
030e3a79cb Buffer overflow fix. 2008-08-25 11:57:46 +00:00
Martin Mares
057021df0d Fix behavior of ipa_opposite(). 
It was giving wrong results on /30 networks.
 2008-08-25 11:19:49 +00:00
Ondrej Filip
3c3271d9fc Close fd of config file after reconfiguration. 2008-08-24 23:24:14 +00:00
Martin Mares
8411a37e7d Detach from the TTY properly. 2007-06-20 07:33:26 +00:00
Ondrej Filip
c025b85273 Real write is only in sk_maybe_write. Previous change partially reverted. 
Thank you MJ.
 2005-02-14 23:15:04 +00:00
Ondrej Filip
7c49f71559 Added s->err_hook wrapper that empties socket. 2005-02-14 21:28:51 +00:00
Ondrej Filip
030d3b387e Small changed to reduce the number of warnings. 2005-02-14 11:58:46 +00:00
Ondrej Filip
0d3effcf8c Time added in password management. 2005-02-12 22:27:55 +00:00
Ondrej Filip
09e4117cc1 sk_write bugfix for BSD. 2004-06-18 12:54:53 +00:00
Ondrej Filip
b7e9c74cba Used parameter can be marked as unused. :-) Thanx MJ. 2004-06-07 16:51:23 +00:00
Ondrej Filip
19d9e30336 Marked unused parameters as unused. 2004-06-07 09:52:15 +00:00
Ondrej Filip
41c8976e29 Test old instance of BIRD. 2004-06-06 17:05:25 +00:00
Martin Mares
6578a60493 Marked unused parameters in sysdep code as such. 2004-06-05 09:11:07 +00:00
Martin Mares
e98bc2ea9b Renamed log() to log_msg(), but still keeping the old name as a macro. 
This is done to avoid clashes with gcc-3.3 which has built-in logarithms :)
 2004-06-05 09:05:12 +00:00
Martin Mares
4da25acb0a Cleaned up sk_reallocate() and friends. 
Also, removed the `if (s)' test, because I believe that as the whole
socket interface doesn't accent NULL pointers, sk_reallocate() shouldn't
be the only exception.
 2004-06-05 08:56:43 +00:00
Ondrej Filip
e7ef86a58c OSPF is ready for changing MTU. 2004-06-04 18:51:29 +00:00
Ondrej Filip
7d72aadb8a CONFIG_SKIP_MC_BIND added. 
BSD hates it, Linux needs it.
 2004-06-03 08:18:14 +00:00
Ondrej Filip
cb4dd4e2f7 Deleted useless rfree. (Socked was freed by cli_free()) 2004-06-02 15:14:49 +00:00
Ondrej Filip
b613b9928b #ifdef CONFIG_UNIX_DONTROUTE added. 2004-06-01 10:32:02 +00:00
Martin Mares
ea0ac8f69a Move CLI socket to the newly created CLI's pool. 
(thanks to Andreas for the original idea)
 2004-05-31 22:00:18 +00:00
Martin Mares
38a608c55a Rewritten the I/O loop. All socket operations are now safe, meaning that 
you can delete the socket from anywhere in the hooks and nothing should break.
Also, the receive/transmit buffers are now regular xmalloc()'ed buffers,
not separate resources which would need shuffling around between pools.

sk_close() is gone, use rfree() instead.
 2004-05-31 21:48:19 +00:00
Martin Mares
5f2a6a9ff3 Fix handling on full pipe to client in bird. Prevent packet overflows 
for even only medium sized route table output. Fix a strange garbled
output problem in the client. The latter seems to be caused by some
library doing tcflush while there is still command output pending. So
the best fix here is to do fflush and then tcdrain. Note that this
problem occurs only under certain load situations and is not too easy to
reproduce.

(by Andreas)
 2004-05-31 17:55:30 +00:00
Ondrej Filip
c222500d8e Previous change was mistake. 2004-05-31 17:00:22 +00:00
Ondrej Filip
b1a1fabac7 *BSD port added. (Tested on FreeBSD and NetBSD) 2004-05-31 13:25:00 +00:00
Martin Mares
c197d44e17 This probably IS the memory leak we're looking for. Alien routes weren't 
correctly disposed of.
 2003-08-13 22:07:55 +00:00
Martin Mares
7d875e094b Added missing includes. 2002-11-13 08:47:06 +00:00
Martin Mares
a19cd81100 Added missing #include and wondering how could it ever compile. 2002-11-13 08:30:56 +00:00
Martin Mares
01b776e117 Fixed <time.h> vs. <sys/time.h> problems. 2001-03-06 13:40:39 +00:00
Martin Mares
f9eb8f7e06 If compiled with --enable-debug, don't even try to log to syslog unless 
the user forces it in the config file.
 2000-06-19 23:50:02 +00:00
Martin Mares
4daf03e513 Use our own SUN_LEN if libc doesn't provide it. 2000-06-16 23:12:47 +00:00
Martin Mares
5ddf4a58f9 During initialization, log to both syslog and stderr. When a configuration 
file has been read and it doesn't specify any logging, log to syslog only
(if syslog is not available, then stderr).
 2000-06-09 07:32:57 +00:00
Martin Mares
0b3bf4b1d8 Use SUN_LEN() for length of UNIX domain addresses. This should fix problems 
with connection to clients on libc5 machines.
 2000-06-09 07:30:22 +00:00
Martin Mares
725270cb1d Fixes for the programmer's manual. 2000-06-08 12:37:21 +00:00
Martin Mares
c62d1c19a9 ... as well there. 2000-06-08 10:48:51 +00:00
Martin Mares
ec423cc725 Updated CLI helps. 2000-06-08 10:25:02 +00:00
Martin Mares
58f7d004fd Fixes to the progdoc. 2000-06-07 13:25:53 +00:00
Martin Mares
2e9b24211a Spelling fixes to progdoc. 2000-06-07 12:29:08 +00:00
Martin Mares
73275d855d Documented all the sysdeps (only briefly, I admit). 
Except for Filters, RIP and OSPF, the progdocs are complete.
 2000-06-05 12:49:04 +00:00
Martin Mares
525fa2c1f0 Documented sockets, events and timers. 2000-06-05 12:19:12 +00:00
Martin Mares
10304bed43 Split random number functions off io.c, so that they can be documented 
separately.
 2000-06-05 11:46:40 +00:00
Martin Mares
b594ad2386 tm_format_reltime() works with both past and future timestamps. 2000-06-01 15:13:23 +00:00
Martin Mares
4a91150175 Updated for new scope handling. 
Also, provide proper address scopes in struct ifa.
 2000-06-01 12:58:41 +00:00
Martin Mares
2f5e5ff9d6 Before configuration file is read, log to _both_ syslog and stderr. 2000-05-31 22:28:36 +00:00
Martin Mares
fcb5f4a725 Updated all the Doc files to new format. 2000-05-31 11:30:18 +00:00
Martin Mares
4761efdb43 Tracing of CLI connections/commands can be now controlled 
by `debug commands <level>' in the configuration. Level 0 means
no tracing, 1 means connections only, 2 includes all commands.
 2000-05-29 22:10:18 +00:00
Martin Mares
e67af42805 Support --version and --help. 2000-05-29 21:58:35 +00:00
Martin Mares
f990fc61e0 When in persist mode, don't delete routes from kernel tables even if 
they cease to exist in our routing tables due to protocols having shut down.
 2000-05-16 13:36:38 +00:00
Martin Mares
02bd064ab7 Adapted to new rt_notify semantics. 2000-05-13 11:02:02 +00:00
Martin Mares
5ff0a270cb In non-debug mode, set default logging to syslog only, not stderr. 2000-05-08 22:31:58 +00:00
Martin Mares
4524331a3d Fixed type in daemonization code. 2000-05-08 22:31:34 +00:00
Martin Mares
0bcba21e89 When not debugging, daemonize automatically. 2000-05-08 19:10:36 +00:00
Martin Mares
818ff1e2b7 When reporting a bug(), call abort() instead of exit(), so that we 
can analyse the core.
 2000-05-08 12:38:00 +00:00
Martin Mares
c304392e65 Some less socket error messages. 2000-05-08 12:37:39 +00:00
Martin Mares
9cbf43eb8a Don't report refused connections. 2000-05-08 12:09:10 +00:00
Martin Mares
916c8c0aba Use preferences properly. 2000-05-08 10:40:00 +00:00
Martin Mares
1151401e2b Don't crash when reporting deleted routes. 
Set preferences correctly.
 2000-05-08 10:38:51 +00:00
Martin Mares
ab1129c1bd Added skeleton Doc files for the whole developer's documentation. 2000-05-05 17:17:42 +00:00
Martin Mares
9a220cabbc #ifdef out lots of debugging information. 
The long resource/routing table dump printed upon startup is gone now
and if you wish to see it, just send bird SIGUSR1 or use the `debug'
commands.
 2000-05-04 20:52:28 +00:00
Martin Mares
93a786cb03 Removed a lot of unused variables. 
Please try compiling your code with --enable-warnings to see them. (The
unused parameter warnings are usually bogus, the unused variable ones
are very useful, but gcc is unable to control them separately.)
 2000-05-04 20:30:36 +00:00
Martin Mares
2edb31b097 Split CF_HDR section to CF_HDR (only includes) and CF_DEFINES (defines, 
C declarations etc.).
 2000-04-28 15:11:10 +00:00
Martin Mares
f75e3bbc01 Fixed a couple of nasty CLI bugs which were triggered on long or multi-part 
outputs. It took a whole evening to hunt them down, but now the CLI seems
to work fine.

Now I run three BGP connections with several thousand routes!
 2000-04-27 22:35:08 +00:00
Martin Mares
e1ddd99377 Changed handling of incoming connections, so that we can send data 
from the send hook without worrying about existence of socket buffers.

Also, don't forget to copy peer addresses.
 2000-04-26 13:26:11 +00:00
Martin Mares
0cadd5f531 Removed several FIXME's. 2000-04-26 12:33:37 +00:00
Martin Mares
00c0c18aea Allow sk_close(NULL). 2000-04-25 23:07:47 +00:00
Martin Mares
f380aa60fa IPv6 compiles with glibc 2.1. 2000-04-20 23:05:41 +00:00
Martin Mares
3991d84e8f Changed initialization of protocol list -- now we call proto_build() instead 
of calling the protocols manually.

Implemented printing of dynamic attributes in `show route all'.

Each protocol can now register its own attribute class (protocol->attr_class,
set to EAP_xxx) and also a callback for naming and formatting of attributes.
The callback can return one of the following results:

	GA_UNKNOWN	Attribute not recognized.
	GA_NAME		Attribute name recognized and put to the buffer,
			generic code should format the value.
	GA_FULL		Both attribute name and value put to the buffer.

Please update protocols generating dynamic attributes to provide
the attr_class and formatting hook.
 2000-04-01 10:19:47 +00:00
Martin Mares
a37410cbdd Use bsprintf() instead of sprintf(). 2000-03-31 23:33:03 +00:00