bird/proto
Ondrej Zajicek (work) c1632ad0f3 OSPF: Fix handling of unnumbered PtPs
This issue has a long history. In 2012, we changed data field for
unnumbered PtP links from iface id (specified by RFC) to IP address based
on reports of bugs in Quagga that required it, and we used out-of-band
information to distinquish unnumberred PtPs with the same local IP
address.

Then with OSPF graceful restart implementation, we found that we can no
longer use out-of-band information, and we need to use only LSAdb info
for routing table calculation, but i forgot to finish handling of this
case, so multiple unnumbered PtPs with the same local IP addresses were
broken.

Considering that even recent Mikrotik RouterOS has broken next hop
calculation that depends on IP address in PtP link data field, we
cannot just switch back to the iface id for unnumbered PtP links.

The patch makes two changes: First, it goes back to use out-of-band
(position) info for distinguishing local interfaces in SPF when graceful
restart is not enabled, while still uses LSAdb-only approach for SPF
calculation when graceful restart is enabled.

Second, it adds OSPF interface option 'ptp address', which controls
whether IP address or iface id is used in data field. It is enabled
by default except for unnumbered PtP links with enabled graceful
restart.

Thanks to Kenth Eriksson for the bugreport and Joakim Tjernlund for
suggestions.
2020-05-26 18:21:43 +02:00
..
babel Nest: Added const to ea_show just to declare that this shouldn't really change anything 2020-05-01 15:19:12 +02:00
bfd BFD: Option to specify which class of BFD sessions are accepted 2020-01-28 18:07:25 +01:00
bgp Merge remote-tracking branch 'origin/mq-static-analysis' 2020-05-01 15:34:17 +02:00
mrt Configuration strings are constant. 2020-04-09 15:37:14 +02:00
ospf OSPF: Fix handling of unnumbered PtPs 2020-05-26 18:21:43 +02:00
perf Perf: changed route update pattern to be more like common protocols 2020-03-12 09:26:05 +01:00
pipe Doc: Rename code documentation files back to Doc 2018-12-14 02:03:42 +01:00
radv Nest: Added const to ea_show just to declare that this shouldn't really change anything 2020-05-01 15:19:12 +02:00
rip RIP: Triggered RIP (demand circuit) documentation 2020-05-19 02:42:22 +02:00
rpki RPKI: fixed rare va_list leak 2020-05-01 15:19:12 +02:00
static Merge remote-tracking branch 'origin/mq-filter-stack' 2019-07-24 15:38:32 +02:00
Doc Doc: Rename code documentation files back to Doc 2018-12-14 02:03:42 +01:00