Jerry/pacroller
1
0
Fork 0
mirror of https://github.com/isjerryxiao/pacroller.git synced 2024-11-22 15:50:43 +08:00
Code Issues Projects Releases Packages Wiki Activity

NullHandler is causing problem

Browse source
This commit is contained in:
JerryXiao 2021-06-02 16:40:34 +08:00
parent 76b13e8e16
commit ee86bb7648
Signed by: Jerry
GPG key ID: 22618F758B5BE2E5
1 changed files with 6 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
src/pacroller/main.py
View file

@ -131,7 +131,7 @@ def do_system_upgrade(debug=False, interactive=False) -> checkReport:
else: else:
raise MaxRetryReached(f'sync failed {NETWORK_RETRY} times') raise MaxRetryReached(f'sync failed {NETWORK_RETRY} times')
stdout_handler = logging.NullHandler stdout_handler = None
if SAVE_STDOUT: if SAVE_STDOUT:
try: try:
LOG_DIR.mkdir(parents=True, exist_ok=True) LOG_DIR.mkdir(parents=True, exist_ok=True)
@ -142,8 +142,9 @@ def do_system_upgrade(debug=False, interactive=False) -> checkReport:
stdout_handler.setLevel(logging.DEBUG) stdout_handler.setLevel(logging.DEBUG)
except Exception: except Exception:
logging.exception(f"unable to save stdout to {LOG_DIR}") logging.exception(f"unable to save stdout to {LOG_DIR}")
stdout_handler = logging.NullHandler stdout_handler = None
logger.addHandler(stdout_handler) if stdout_handler:
logger.addHandler(stdout_handler)
for _ in range(NETWORK_RETRY): for _ in range(NETWORK_RETRY):
try: try:
@ -160,7 +161,8 @@ def do_system_upgrade(debug=False, interactive=False) -> checkReport:
else: else:
raise MaxRetryReached(f'upgrade failed {NETWORK_RETRY} times') raise MaxRetryReached(f'upgrade failed {NETWORK_RETRY} times')
logger.removeHandler(stdout_handler) if stdout_handler:
logger.removeHandler(stdout_handler)
with open(PACMAN_LOG, 'r') as pacman_log: with open(PACMAN_LOG, 'r') as pacman_log:
pacman_log.seek(log_anchor) pacman_log.seek(log_anchor)