Ondrej Zajicek (work)
b8bbbbaf56
Nest: Fix neighbor handling for colliding ranges
...
Resolve neighbors using longest prefix match. Although interface ranges
should not generally collide, it may happen for unnumbered links.
Thanks to Kenth Eriksson for the bugreport.
2020-05-11 04:29:36 +02:00
Ondrej Zajicek (work)
f7c34aa227
Tests: Activate BGP-int test
2020-05-05 02:20:30 +02:00
Matous Holinka
e6785c469b
Tests: Change unsupported Ubuntu 19.04 for supported version 19.10
2020-05-05 02:16:28 +02:00
Ondrej Zajicek (work)
82bfee76f0
Filter: Remove quitbird command
...
No need for this debug filter command and it can be abused from CLI.
2020-05-02 02:47:18 +02:00
Maria Matejka
b12442c985
Fixed a harmless warning in production build
2020-05-01 15:41:42 +02:00
Maria Matejka
048eb2ddf1
Merge remote-tracking branch 'origin/mq-static-analysis'
2020-05-01 15:34:17 +02:00
Maria Matejka
59238768b3
Slab: Init node in slab head to NULLs.
2020-05-01 15:19:12 +02:00
Maria Matejka
ea259d6201
Timer: Adding missing initializer.
2020-05-01 15:19:12 +02:00
Maria Matejka
0c3b8ffe25
Lexer: strtoul shall never set endptr to NULL; it should be an error
2020-05-01 15:19:12 +02:00
Maria Matejka
cdde3550dc
Unix socket: Path length check directly before copying the path.
...
This is not needed as the string is always short enough, anyway
it may be needed in future and one strlen during BIRD start is
cheap enough.
2020-05-01 15:19:12 +02:00
Maria Matejka
9ac13d7af2
Lists: Replaced replace_node() by update_node() which is the only use of that function.
2020-05-01 15:19:12 +02:00
Maria Matejka
e26a5195dd
Lists: fix a stupid sanitizer bug
2020-05-01 15:19:12 +02:00
Maria Matejka
3bb10b4d31
Uninitialized list nodes fixes
2020-05-01 15:19:12 +02:00
Maria Matejka
258be56539
Nest: Added const to ea_show just to declare that this shouldn't really change anything
2020-05-01 15:19:12 +02:00
Maria Matejka
a7d9b8f116
OSPF: Zero-initialization of a temporary neighbor
2020-05-01 15:19:12 +02:00
Maria Matejka
0fa8bf91cd
Nest: Several assumptions to tame the static analyzer
2020-05-01 15:19:12 +02:00
Maria Matejka
bbe49ae569
Nest: Assumption in rt-show for not-so-intuitive invariant.
2020-05-01 15:19:12 +02:00
Maria Matejka
a08853a269
Static scanner and expensive debugging setup fix
2020-05-01 15:19:12 +02:00
Maria Matejka
5f60d14ede
RPKI: fixed rare va_list leak
2020-05-01 15:19:12 +02:00
Maria Matejka
b748220906
Static check: Don't report dead code
2020-05-01 15:19:12 +02:00
Maria Matejka
9e64ac4b7c
OSPF: Adding a note about a static analyzer result.
2020-05-01 15:19:12 +02:00
Maria Matejka
dccee40826
OSPF: variable-length array of size 0 replaced by alloca()'d pointer
...
NULL pointer is safer than a random pointer onto stack if this function
gets changed and eventually broken.
2020-05-01 15:19:12 +02:00
Maria Matejka
baac700906
List expensive check.
2020-05-01 15:19:12 +02:00
Maria Matejka
a0d0a71a18
Expensive check declaration
...
Intended to be run at every operation with complex data structures
to check their consistency and validity.
2020-05-01 15:19:12 +02:00
Maria Matejka
a1b61a271a
IPv6 address parser: fail on incomplete addresses
2020-05-01 15:19:12 +02:00
Maria Matejka
d65a926a67
Filter: Don't alloc varargs array if its length would be zero
2020-05-01 15:19:12 +02:00
Maria Matejka
30ba7c1661
Filter: Removed forgotten dead code
2020-05-01 15:19:12 +02:00
Maria Matejka
bf9486bf20
Non-null function argument declaration
2020-05-01 15:18:48 +02:00
Ondrej Zajicek (work)
17de3a023f
BGP: Fix handling of strange IPv6 link-local-only next hops
...
There are three common ways how to encode IPv6 link-local-only next hops:
(:: ll), (ll), and (ll ll). We use the first one but we should accept all
three. The patch fixes handling of the last one.
Thanks to Sebastian Hahn for the bugreport.
2020-04-29 02:50:29 +02:00
Maria Matejka
8029ae527e
More assertion categories
2020-04-28 16:21:06 +02:00
Maria Matejka
d607205486
Not calling memcpy with n=0.
2020-04-28 16:21:06 +02:00
Maria Matejka
124d860f64
Filter: fixed omitted overflow check in EC constructor
2020-04-28 16:21:06 +02:00
Maria Matejka
59a86cbc7c
Makefile rule for static analyzer
2020-04-28 16:21:06 +02:00
Ondrej Zajicek (work)
b465604eb1
Tests: Activate BGP-auth test
2020-04-28 15:26:26 +02:00
Ondrej Zajicek (work)
716e11a584
Tests: Activate OSPF-VRF test
2020-04-28 03:52:47 +02:00
Ondrej Zajicek (work)
3c838ad9fd
Tests: Activate BGP test
2020-04-22 17:14:02 +02:00
Nasato Goto
a6548d5b5b
BGP: Fix handling of 16bit-only ASN translation
...
The bug generated invalid AGGREGATOR attribute during translation of
32bit ASN to 16bit-only BGP peer. The patch fixes that.
2020-04-15 03:46:53 +02:00
Maria Matejka
fd9f0c0640
Configuration strings are constant.
...
This is merely a const propagation. There was no problem in there.
2020-04-09 15:37:14 +02:00
Ondrej Zajicek (work)
a109056145
Doc: Update prefix set comment
2020-04-08 13:11:51 +02:00
Maria Matejka
2928c5bcc7
Fletcher16 test fixed to work at bigendian architectures.
...
To be honest, it was wrong in concept, anyway it accidentally worked.
2020-04-05 01:15:26 +02:00
Ondrej Zajicek (work)
c9d11e6230
Filter: Remove mixed address tests and fix formatting
2020-03-26 04:59:15 +01:00
Ondrej Zajicek (work)
2755002890
Filter: Optimize IPv4 prefix sets
...
Use separate IPv4 and IPv6 implementation of prefix sets. Just this
change makes IPv4 prefix sets 60% smaller and 50% faster.
2020-03-26 03:57:48 +01:00
Ondrej Zajicek (work)
d516c68ad8
RIP: Improvements to demand circuit mode
...
Restart iface after changing demand circuit mode during reconfiguration.
Fix next_regular interval reset during reconfiguration. Send flushing
response when iface goes down.
2020-03-14 17:04:49 +01:00
Maria Matejka
dc042d87cb
Perf: changed route update pattern to be more like common protocols
2020-03-12 09:26:05 +01:00
Ondrej Zajicek (work)
e2630a494e
Netlink: Handle interfaces with missing broadcast addresses
2020-03-07 05:11:21 +01:00
Ondrej Zajicek (work)
1ad98965c5
Tests: Enforce cleanup before running a test
2020-03-05 22:01:30 +01:00
Ondrej Zajicek (work)
ead531ffef
Tests: Activate OSPF tests
2020-03-05 17:39:52 +01:00
Ondrej Zajicek (work)
e6746da6de
Flowspec: Fix tests
...
Missing dst no longer generates error.
2020-03-03 19:04:33 +01:00
Ondrej Zajicek (work)
78e4a123bb
BGP: Handle flowspec rules without dst part
...
The RFC 5575 does not explicitly reject flowspec rules without dst part,
it just requires dst part in validation procedure for feasibility, which
we do not implement anyway. Thus flow without dst prefix is syntactically
valid, but unfeasible (if feasibilty testing is done).
Thanks to Alex D. for the bugreport.
2020-03-03 17:45:16 +01:00
Ondrej Zajicek (work)
757cab18d6
BGP: Support for MD5SIG together with remote range
...
When dynamic BGP with remote range is configured, MD5SIG needs to use
newer socket option (TCP_MD5SIG_EXT) to specify remote addres range for
listening socket.
Thanks to Adam Kułagowski for the suggestion.
2020-02-27 17:29:17 +01:00
