Jerry/bird
1
0
Fork 0
Code Issues Pull requests Packages Projects Releases Wiki Activity
2629 commits 6 branches 1 tag 7.1 MiB
Commit graph

2629 commits

This branch
This branch
All branches
Author SHA1 Message Date
Ondrej Zajicek 77edab6409 OSPF: Redesign LSA checksumming 
New LSA checksumming code separates generic Fletcher-16 and OSPF-specific
code and avoids back and forth endianity conversions, making it much more
readable and also several times faster.
 2015-05-01 14:40:56 +02:00
Ondrej Zajicek 30d09eb96e OSPF: Fixes validation of LSA checksums 
Prior to this patch, BIRD validates the OSPF LSA checksum by calculating
a new checksum and comparing it with the checksum in the header. Due to
the specifics of the Fletcher checksum used in OSPF, this is not
necessarily correct as the checkbytes in the header may be calculated via
a different means and end up with a different value that is nonetheless
still correct.

The documented means of validating the checksum as specified in RFC 905
B.4 is to calculate c0 and c1 from the unchanged contents of the packet,
which must result in a zero value to be considered valid.

Thanks to Chris Boot for the patch.
 2015-04-28 13:45:44 +02:00
Ondrej Zajicek 7069fc9e72 KRT: Fixes route reload 
Did not really worked
 2015-04-25 21:41:43 +02:00
Ondrej Zajicek c5ff44a703 KRT: Fixes learning of preferred kernel routes. 
When a new route was imported from kernel and chosen as preferred, then
the old best route was propagated as a withdraw to the kernel protocol.
Under some circumstances such withdraw propagated to the BSD kernel could
remove the new alien route and thus reverting the import.
 2015-04-25 20:43:43 +02:00
Ondrej Zajicek 90097f4fb9 KRT: Support for RTM_CHANGE on BSD 2015-04-22 10:53:15 +02:00
Ondrej Zajicek deec752ef9 NEWS and version update 2015-04-20 12:27:00 +02:00
Ondrej Zajicek b867a87c2f Fixes port range socket option 2015-04-19 00:31:59 +02:00
Ondrej Zajicek ef3cac669c OSPF: Fixes handling of external routes with immediate gw 
The bug caused that received external LSAs with locally reachable
next hops were ignored. I wonder why nobody noticed it sooner.
 2015-04-18 13:26:45 +02:00
Ondrej Zajicek 304ac2e861 Minor fixes 2015-04-12 10:47:17 +02:00
Ondrej Zajicek d924d5a562 BGP: Fixes serious bug in TX handling 
Under some circumstances and heavy load, TX could be postponed
until the session fails with hold timer expired.

Thanks to Javor Kliachev for making the bug reproductible.
 2015-04-01 00:10:00 +02:00
Ondrej Zajicek 16a3254c4c Understand IFF_MULTICAST flag on ifaces in Linux 
Unfortunately, some interfaces support multicast but do not have
this flag set, so we use it only as a positive hint.

Thanks to Clint Armstrong for noticing the problem.
 2015-03-31 23:59:40 +02:00
Ondrej Zajicek 2eadd36fa0 BGP: AS-wide unique router ID (RFC 6286) support 
RFC 6286 relaxed rules for router IDs, allowing EBGP sessions between
routers with the same ID (but different ASN).
 2015-03-29 21:24:47 +02:00
Ondrej Zajicek 9aed29e605 BGP: Enhanced route refresh (RFC 7313) support 
Also hook feed_done is renamed to feed_end.
 2015-03-29 18:29:49 +02:00
Ondrej Filip a5a5a41e2e Possibility to define unnamed protocols from template added. 2015-03-09 23:59:26 +01:00
Ondrej Zajicek 509aab5deb Fixes serious bug in BGP add-path 
Temporary rta is reused in BGP, while rta_lookup() breaks it.

Thanks to Alexander Chernikov for analysing the problem.
 2015-03-02 10:58:20 +01:00
Ondrej Zajicek af454f9b7c Fixes bug in debug dumps 
Using 'dump sockets' in IPv6 mode caused crash due to mismatched format string.

Thanks to Pavel Tvrdik for noticing it.
 2015-03-02 09:42:44 +01:00
Ondrej Zajicek 8bcb5fb1e8 Implement latency tracking, internal event log and watchdog 2015-03-02 09:41:14 +01:00
Ondrej Zajicek 4e63974471 Add minor comment 2015-02-24 16:19:14 +01:00
Ondrej Zajicek 9c89560e6c Use IP_PORTRANGE_HIGH for BFD where available 2015-02-22 20:14:14 +01:00
Ondrej Zajicek 6cf72d7ad7 Rename BGP option 'start delay' to 'connect delay' 
Also update log message for error-triggered startup delay.
 2015-02-22 17:21:54 +01:00
Ondrej Zajicek a1beb8f3ee Relax BGP neighbor parameter 
Permit specifying neighbor address, AS number and port independently.
Add 'interface' parameter for specifying interface for link-local
sessions independently.

Thanks to Alexander V. Chernikov for the original patch.
 2015-02-22 13:50:58 +01:00
Ondrej Zajicek 86c3eea0f3 Use AF_UNSPEC for RTM_GETLINK 
This value is specified in documentation.
 2015-02-21 21:19:49 +01:00
Ondrej Zajicek 2bbc308321 Store protocol config size inside protocol structure 
Make proto_config_new() use this info instead of supplied size.

Thanks to Alexander V. Chernikov for the patch.
 2015-02-21 21:08:23 +01:00
Ondrej Zajicek 374917adcc Make BGP protocol instance search a separate function 
Thanks to Alexander V. Chernikov for the patch.
 2015-02-21 20:55:43 +01:00
Pavel Tvrdík 6264aad16f Minor fixes 2015-02-21 20:11:02 +01:00
Pavel Tvrdik 85a3639d99 Better Clang compatibility 2015-02-21 20:07:17 +01:00
Pavel Tvrdik 7d37bf79de Remove a comparison of unsigned expression < 0 2015-02-21 19:38:44 +01:00
Pavel Tvrdik e598853e68 Add const to a param msg at functions log_msg, log_rl, die, bug and debug 2015-02-21 19:32:57 +01:00
Pavel Tvrdik 4a591d4b94 Replacing GNU old-style field designator extension 2015-02-21 19:31:36 +01:00
Ondrej Zajicek 8ce9a87755 Fixes minor bug in BFD. 
Thanks to Pavel Tvrdik for noticing it.
 2015-02-21 14:52:17 +01:00
Ondrej Zajicek 51762a45b3 Allows user data attached to f_trie_node structure. 
Thanks to Alexander Chernikov for the patch.
 2015-02-21 14:05:20 +01:00
Ondrej Zajicek bc7f4e0e34 Bump max symbol length to 64. 
And move the constant to conf.h header.

Thanks to Alexander Chernikov for the patch.
 2015-02-21 12:42:31 +01:00
Ondrej Zajicek ab00639130 Fixes a bug in locking code. 
When multiple protocols have a lock for the same IP address, it crashes
under some circumstances.

Thanks to Matthias Schiffer for the bugreport.
 2015-02-21 12:30:14 +01:00
Ondrej Zajicek dfc7a6c6a0 Fixes potential alignment bug in BGP. 
Thanks to Andrew (seti.kr.ua) for the bug report.
 2015-02-21 12:24:30 +01:00
Ondrej Zajicek 523f020b5f Link state support in BGP. 
Configurable fast shutdown of a BGP session when an interface loses link.
 2015-02-21 12:15:56 +01:00
Ondrej Zajicek 7730553b7e Merge remote-tracking branch 'origin/soft-int' 2015-02-21 11:39:45 +01:00
Ondrej Zajicek 0da562a7cb Fixes error message in 'show route' cmd. 
Message 'Network not in table' was not reported if a network node without
any routes was found in a routing table.
 2014-11-08 23:52:42 +01:00
Ondrej Filip ec2194fa7a Version 1.5.0pre 2014-11-05 11:07:25 +01:00
Ondrej Filip dd5ef279bc Small typo fixed. 2014-11-04 18:11:59 +01:00
Ondrej Zajicek f92e6ab364 Changes order of iface/addr/neigh event hooks. 
Now the order is:

Up   -> iface, addr, neigh
Down -> neigh, addr, iface

It fixes the case when an iface appears, related static routes are
activated and exported to OSPF before the iface notification and
therefore forwarding addresses are not encoded in generated external
LSAs.
 2014-11-03 20:35:58 +01:00
Ondrej Zajicek ac9dc669d8 Bugfix in latest OSPF changes. 2014-11-03 20:35:25 +01:00
Ondrej Zajicek cd3b700393 Bugfix to OSPF reconfiguration. 2014-11-03 14:53:59 +01:00
Ondrej Zajicek 6f8bbaa10b Fininshing integrated OSPF. 2014-11-03 10:42:55 +01:00
Ondrej Filip d148d0af36 Mailling list location changed. 2014-10-25 21:08:35 +02:00
Ondrej Zajicek 88a183c6c9 Integrated IP functions. 2014-10-24 11:11:43 +02:00
Ondrej Zajicek f8fefde318 Refactoring of OSPF messages. 2014-10-24 11:07:38 +02:00
Ondrej Filip d26cfa0519 __attribute__((packed)) added. Thank to Maksim Tamarsky 2014-10-16 18:05:54 +02:00
Ondrej Zajicek 78342404ff Merge remote-tracking branch 'origin/master' into soft-int 2014-10-14 17:23:34 +02:00
Ondrej Zajicek cfdea7b85f NEWS and version update. 2014-10-05 23:59:18 +02:00
Ondrej Zajicek 7aa809016e Implements show route noexport option. 
Shows routes that would be exported to the protocol but are rejected by
the export filter.
 2014-10-02 12:52:50 +02:00